TimeSliderChoropleth sort over daterange '2001-09-09' #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Sep 13, 2021
Ade-StapleHill
force-pushed
the
choropleth_sort
branch
from
8b919fe to
cadd324
Compare
…ion#1502) For description of problem see: [plugins.TimeSliderChoropleth() time slider bar out of order for date range that spans '2001-09-09' python-visualization#1502](python-visualization#1502) Files changed: folium/plugins/time_slider_choropleth.py: - try numeric sort first - if not numeric e.g. date strings, and exception thrown, then fall back to generic sort. - Problem if string as alphabetic sort ('2' > '10') may result in out of order tests/plugins/test_time_slider_choropleth.py: - No longer expected fail - Avoid hardwiring in timestamp values - Avoid the convenient call to datetime.strftime('%s') for timestamps as Windows only returns string date - Carefully chosen date range to span 2001-09-09 Ran tests and qa: - flake8 --max-line-length=120 tests/plugins/test_time_slider_choropleth.py folium/plugins/time_slider_choropleth.py - python -m pytest tests/plugins/test_time_slider_choropleth.py (previous commit fixed xfail)
ocefpaf
force-pushed
the
choropleth_sort
branch
from
9b3ac0d to
3ca4aeb
Compare
Member
|
Thanks @Ade-StapleHill! |
This was referenced Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1502
First commit of change to the TimeSliderChoropleth test so its no longer an expected fail is
worth taking even if the TimeSliderChoropleth plugin source change is rejected.