Revert "Bootstrap 5 (#1644)" #1648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4e6e6e4.
Merged
| 'https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css'), | ||
| # glyphicons came from Bootstrap 3 and are used for Awesome Markers | ||
| ('glyphicons_css', | ||
| 'https://cdn.jsdelivr.net/gh/python-visualization/folium/folium/templates/bootstrap_3_glyphicons/bootstrap-3-glyphicons.css'), # noqa |
There was a problem hiding this comment.
The reason for the error is this file doesn't exist in the repo, see: https://github.com/python-visualization/folium/tree/v0.13.0/folium/templates/bootstrap_3_glyphicons/bootstrap-3-glyphicons.css
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4e6e6e4.
The jsdelivr CDN is not accepting this approach, saying: "Package size exceeded the configured limit of 50 MB." I guess it processes the entire folium repo, and complains that's too big? Let's look into it, but in the meantime make the main branch working again.