Add Leaflet.encoded plugin: Enable creating PolyLine and Polygon from encoded string
#1928
Conversation
Added type information to for argument to `__init__`
|
In hindsight, I'm also considering adding the second functionality the original author provides - |
Do you want to include this in this PR? If so, go ahead, but you can also do it in a later PR. |
achieveordie
changed the title
Leaflet.encoded plugin: Enable creating PolyLine and Polygon from encoded string
|
done @hansthen :) |
|
How long before this can be merged? I'd like to use the 'official' feature :) |
folium/plugins/encoded.py
Outdated
| super().__init__( | ||
| encoded, | ||
| ) | ||
| path_options(line=True, radius=None, **kwargs) |
There was a problem hiding this comment.
Thanks for the quick response! This is not working yet, I suppose you mean to pass these to the super init? Also in the other class.
|
@Conengmo I appreciate your input on the error. It was an oversight on my end. This PR should be good to go. |
…om encoded string (python-visualization#1928) * add plugin to visualize the polyline from an encoded string * correct import in user guide * Update polyline_encoded.py Added type information to for argument to `__init__` * rework encoded plugin to include PolygonFromEncoded * include doc and tests for PolygonFromEncoded * update doc to include the link of the algo * use path_options instead of parse_options * set path_options to an attribute --------- Co-authored-by: Hans Then <[email protected]>
Fixes #1886
PolyLineFromEncoded, which accepts an encoded string to make a polyline. Also, add all the relevant docs/tests required for plugin approval.PolygonFromEncoded, which works the same way as above, but for polygons.FYI @hansthen