Skip to content

Remove autolink to bpo ticket. #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Mariatta
Copy link
Member

We get autolinking for free now.

Closes python/core-workflow#361

We get autolinking for free now.

Closes python/core-workflow#361
@brettcannon
Copy link
Member

@Mariatta in case you didn't see the test failures.

@brettcannon brettcannon self-requested a review October 18, 2019 21:57
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_bpo also needs to be updated.

@methane
Copy link
Member

methane commented Dec 19, 2019

bedevere/bedevere/bpo.py

Lines 15 to 17 in 363b02e

<!-- {TAG_NAME}: bpo-{{issue_number}} -->
https://bugs.python.org/issue{{issue_number}}
{CLOSING_TAG}

This can be Ref: bpo-{issue_number} too.
It will make auto merged commit message less ugly.

@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #196 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #196   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines        1662   1662           
  Branches       89     89           
=====================================
  Hits         1662   1662
Impacted Files Coverage Δ
bedevere/stage.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb3786...78b15e2. Read the comment docs.

@nightlark
Copy link

If it helps wrap up this PR (it looks like the GitHub autolinking feature works but the bot is still rewriting bpo- refs in commits), here are two patches that I think address the review comments:

@arhadthedev
Copy link
Member

Is there any blocker? This PR is stuck for two years.

@ambv
Copy link
Contributor

ambv commented Apr 10, 2022

This is outdated now.

@ambv ambv closed this Apr 10, 2022
@brettcannon brettcannon deleted the remove-bpo-autolink branch April 11, 2022 21:46
@brettcannon brettcannon restored the remove-bpo-autolink branch April 11, 2022 21:46
@CAM-Gerlach
Copy link
Member

@brettcannon @Mariatta Could this upstream branch be moved or removed now, to avoid partially blocking full implementation of python/workflow#460 on this repo?

@Mariatta
Copy link
Member Author

Mariatta commented Jan 4, 2023

Since this is outdated we don't need to keep it around, so I'll delete it. Thanks.

@Mariatta Mariatta deleted the remove-bpo-autolink branch January 4, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable GitHub's autolink to external issue tracker
8 participants