Skip to content

Improve test coverage on pdb #102980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gaogaotiantian opened this issue Mar 23, 2023 · 4 comments
Closed

Improve test coverage on pdb #102980

gaogaotiantian opened this issue Mar 23, 2023 · 4 comments
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@gaogaotiantian
Copy link
Member

gaogaotiantian commented Mar 23, 2023 •
edited by bedevere-app bot
Loading

Feature or enhancement

Add more tests on pdb module

Pitch

The coverage on pdb module is poor - some of the commands are not tested at all. There are at least some low hanging fruits that we can do.

Linked PRs
@gaogaotiantian gaogaotiantian added the type-feature A feature request or enhancement label Mar 23, 2023
@bedevere-bot bedevere-bot mentioned this issue Mar 23, 2023
Merged
iritkatriel pushed a commit that referenced this issue Mar 24, 2023
@gaogaotiantian
gh-102980: Add tests for pdf's display, alias and where commands (#10…
ded9a7f 
…2981)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 24, 2023
@gaogaotiantian @miss-islington
pythongh-102980: Add tests for pdf's display, alias and where commands (
a5840fa 
pythonGH-102981)

(cherry picked from commit ded9a7f)

Co-authored-by: gaogaotiantian <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Mar 24, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 24, 2023
@gaogaotiantian @miss-islington
pythongh-102980: Add tests for pdf's display, alias and where commands (
9b70ff2 
pythonGH-102981)

(cherry picked from commit ded9a7f)

Co-authored-by: gaogaotiantian <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Mar 24, 2023
Merged
miss-islington added a commit that referenced this issue Mar 24, 2023
@miss-islington @gaogaotiantian
gh-102980: Add tests for pdf's display, alias and where commands (GH-…
d3b4d3a 
…102981)

(cherry picked from commit ded9a7f)

Co-authored-by: gaogaotiantian <[email protected]>
miss-islington added a commit that referenced this issue Mar 24, 2023
@miss-islington @gaogaotiantian
gh-102980: Add tests for pdf's display, alias and where commands (GH-…
a08b65f 
…102981)

(cherry picked from commit ded9a7f)

Co-authored-by: gaogaotiantian <[email protected]>
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@gaogaotiantian @Fidget-Spinner
pythongh-102980: Add tests for pdf's display, alias and where commands (
6b4ce01 
python#102981)
@arhadthedev
Copy link
Member

Should this issue be closed as done?

@gaogaotiantian
Copy link
Member Author

Please don't close it yet. There are still some missing pieces and I need to wait for #102895 to do test on interact. I'll do more PRs related to this issue.

warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@gaogaotiantian @warsaw
pythongh-102980: Add tests for pdf's display, alias and where commands (
719e599 
python#102981)
@bedevere-app bedevere-app bot mentioned this issue Oct 23, 2023
Merged
@iritkatriel iritkatriel added tests Tests in the Lib/test dir stdlib Python modules in the Lib dir labels Nov 27, 2023
iritkatriel pushed a commit that referenced this issue Dec 7, 2023
@gaogaotiantian
gh-102980: Redirect output of pdb's interact command, add tests and…
3d712a9 
… improve docs (#111194)
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@gaogaotiantian @aisk
pythongh-102980: Redirect output of pdb's interact command, add tes…
ed9935e 
…ts and improve docs (python#111194)
@ambv
Copy link
Contributor

ambv commented Feb 21, 2024

note: #102895 is now complete.

@gaogaotiantian
Copy link
Member Author

Yes, all the intended tests were added already. I'll close this one.

Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@gaogaotiantian @Glyphack
pythongh-102980: Redirect output of pdb's interact command, add tes…
a432107 
…ts and improve docs (python#111194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ambv @iritkatriel @arhadthedev @gaogaotiantian