Skip to content

Argument Clinic silently allow empty custom C basenames #107972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erlend-aasland opened this issue Aug 15, 2023 · 1 comment
Closed

Argument Clinic silently allow empty custom C basenames #107972

erlend-aasland opened this issue Aug 15, 2023 · 1 comment
Labels
topic-argument-clinic type-bug An unexpected behavior, bug, or error

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Aug 15, 2023

See #107964 (comment):

Here's a very contrived example that silently passes on this PR, current main and on 3.12:

/*[clinic input]
output everything block
class C "void *" ""
# Trailing whitespace on following line!!!
C.meth as   
[clinic start generated code]*/

Linked PRs

@erlend-aasland
Copy link
Contributor Author

We should fail() with something like "No C basename provided after 'as' keyword" in this case.

@AlexWaygood AlexWaygood added the type-bug An unexpected behavior, bug, or error label Aug 15, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 15, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this issue Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-argument-clinic type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants