Skip to content

test_xxtestfuzz emits DeprecationWarning #109098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Sep 7, 2023 · 4 comments
Closed

test_xxtestfuzz emits DeprecationWarning #109098

serhiy-storchaka opened this issue Sep 7, 2023 · 4 comments
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Sep 7, 2023 •
edited by bedevere-app bot
Loading

test_xxtestfuzz emits deprecation warnings about modules sre_compile and sre_constants which always were internal. It should use public non-deprecated API.

$ ./python -Wa -m test -v test_xxtestfuzz
...
test_sample_input_smoke_test (test.test_xxtestfuzz.TestFuzzer.test_sample_input_smoke_test)
This is only a regression test: Check that it doesn't crash. ... /home/serhiy/py/cpython/Lib/test/test_xxtestfuzz.py:13: DeprecationWarning: module 'sre_compile' is deprecated
  _xxtestfuzz.run(b"")
/home/serhiy/py/cpython/Lib/test/test_xxtestfuzz.py:13: DeprecationWarning: module 'sre_constants' is deprecated
  _xxtestfuzz.run(b"")
ok
...

cc @ssbr, @ammaraskar

Linked PRs
@serhiy-storchaka serhiy-storchaka added the tests Tests in the Lib/test dir label Sep 7, 2023
@serhiy-storchaka serhiy-storchaka mentioned this issue Sep 7, 2023
Closed
@serhiy-storchaka serhiy-storchaka added 3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes labels Sep 26, 2023
@serhiy-storchaka
Copy link
Member Author

cc @ammaraskar

These tests should be either removed or rewritten using the public API.

@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Sep 26, 2023
ammaraskar added a commit to ammaraskar/cpython that referenced this issue Sep 26, 2023
@ammaraskar
pythongh-109098: Fuzz re module instead of internal sre
be5233d
@bedevere-app bedevere-app bot mentioned this issue Sep 26, 2023
Merged
ammaraskar added a commit to ammaraskar/cpython that referenced this issue Sep 26, 2023
@ammaraskar
pythongh-109098: Fuzz re module instead of internal sre
1e562d7
gpshead pushed a commit that referenced this issue Sep 26, 2023
@ammaraskar
gh-109098: Fuzz re module instead of internal sre (#109911)
a829356 
* gh-109098: Fuzz re module instead of internal sre
* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv
@miss-islington miss-islington mentioned this issue Sep 26, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 26, 2023
@ammaraskar @miss-islington
pythongh-109098: Fuzz re module instead of internal sre (pythonGH-109911
9577d79 
)

* pythongh-109098: Fuzz re module instead of internal sre
* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv
(cherry picked from commit a829356)

Co-authored-by: Ammar Askar <[email protected]>
@miss-islington miss-islington mentioned this issue Sep 26, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 26, 2023
@ammaraskar @miss-islington
pythongh-109098: Fuzz re module instead of internal sre (pythonGH-109911
7d9a97d 
)

* pythongh-109098: Fuzz re module instead of internal sre
* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv
(cherry picked from commit a829356)

Co-authored-by: Ammar Askar <[email protected]>
@gpshead
Copy link
Member

gpshead commented Sep 26, 2023

I believe that PR should fix this. if not, please feel free to reopen. thanks for the PR and reviews!

@gpshead gpshead closed this as completed Sep 26, 2023
serhiy-storchaka pushed a commit that referenced this issue Sep 27, 2023
@miss-islington @ammaraskar
[3.11] gh-109098: Fuzz re module instead of internal sre (GH-109911) (G…
8ed9bda 
…H-109933)

* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv
(cherry picked from commit a829356)

Co-authored-by: Ammar Askar <[email protected]>
@serhiy-storchaka
Copy link
Member Author

Do not miss merging in 3.12 branch.

@serhiy-storchaka
Copy link
Member Author

@gpshead Please do no forgot to edit commit message. It contains a duplicate of the subject and intermediate commit messages.

csm10495 pushed a commit to csm10495/cpython that referenced this issue Sep 28, 2023
@ammaraskar @csm10495
pythongh-109098: Fuzz re module instead of internal sre (python#109911)
6608db3 
* pythongh-109098: Fuzz re module instead of internal sre
* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv
Yhg1s pushed a commit that referenced this issue Oct 2, 2023
@miss-islington @ammaraskar
[3.12] gh-109098: Fuzz re module instead of internal sre (GH-109911) (#…
95fd4ed 
…109932)

gh-109098: Fuzz re module instead of internal sre (GH-109911)

* gh-109098: Fuzz re module instead of internal sre
* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv
(cherry picked from commit a829356)

Co-authored-by: Ammar Askar <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@ammaraskar @Glyphack
pythongh-109098: Fuzz re module instead of internal sre (python#109911)
c526a73 
* pythongh-109098: Fuzz re module instead of internal sre
* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpshead @serhiy-storchaka