Skip to content

Further improve test_future_stmt #109485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Sep 16, 2023 · 0 comments
Closed

Further improve test_future_stmt #109485

sobolevn opened this issue Sep 16, 2023 · 0 comments
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Sep 16, 2023 •
edited by bedevere-app bot
Loading

Bug report

Based on the review of @vstinner in #109368 (review)

I propose to:

  1. Replace badsyntax_future files with regular code samples, so we can more easily manage them
  2. Keep at lest one file to be sure that it also works as intended for modules
  3. Apply better names

I have a PR ready :)

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Sep 16, 2023
@sobolevn sobolevn self-assigned this Sep 16, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 16, 2023
@sobolevn
pythongh-109485: Further improve test_future_stmt tests
fe8d76c
@bedevere-app bedevere-app bot mentioned this issue Sep 16, 2023
Merged
vstinner pushed a commit that referenced this issue Sep 19, 2023
@sobolevn
gh-109485: Further improve test_future_stmt tests (#109486)
94c95d4 
Add assertSyntaxError() which run tests with an additional docstring
and without docstring, and checks for the error message.
csm10495 pushed a commit to csm10495/cpython that referenced this issue Sep 28, 2023
@sobolevn @csm10495
pythongh-109485: Further improve test_future_stmt tests (python#109486
7921882 
)

Add assertSyntaxError() which run tests with an additional docstring
and without docstring, and checks for the error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @sobolevn