Skip to content

if SOURCE_DATE_EPOCH is set, don't randomize the testsuite #110164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asottile opened this issue Sep 30, 2023 · 6 comments
Closed

if SOURCE_DATE_EPOCH is set, don't randomize the testsuite #110164

asottile opened this issue Sep 30, 2023 · 6 comments
Labels
type-feature A feature request or enhancement

Comments

@asottile
Copy link
Contributor

asottile commented Sep 30, 2023 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

cc @vstinner from #109570 (comment)

cc @doko42 @stefanor from debian -- this would allow debian to remove this patch I believe https://salsa.debian.org/cpython-team/python3/-/blob/master/debian/patches/test-no-random-order.diff

if SOURCE_DATE_EPOCH is set test randomization should be disabled

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

#109570 (comment)

Linked PRs
@asottile asottile added the type-feature A feature request or enhancement label Sep 30, 2023
vstinner added a commit to vstinner/cpython that referenced this issue Oct 1, 2023
@vstinner
pythongh-110164: regrtest disables randomize if SOURCE_DATE_EPOCH
9da1830 
If the SOURCE_DATE_EPOCH environment variable is defined, regrtest
now disables randomization of tests.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 1, 2023
@vstinner
pythongh-110164: regrtest disables random if SOURCE_DATE_EPOCH
6b49928 
If the SOURCE_DATE_EPOCH environment variable is defined, regrtest
now disables randomization of tests.
@bedevere-app bedevere-app bot mentioned this issue Oct 1, 2023
Merged
@vstinner
Copy link
Member

vstinner commented Oct 1, 2023

Would you be able to test if my PR gh-110168 fix your issue?

@vstinner
Copy link
Member

vstinner commented Oct 1, 2023

My PR doesn't check SOURCE_DATE_EPOCH value. It only checks if the variable is defined.

@vstinner vstinner mentioned this issue Oct 1, 2023
Merged
@asottile
Copy link
Contributor Author

asottile commented Oct 1, 2023

@vstinner works great -- thanks!

vstinner added a commit that referenced this issue Oct 1, 2023
@vstinner
gh-110164: regrtest disables random if SOURCE_DATE_EPOCH (#110168)
65c2850 
If the SOURCE_DATE_EPOCH environment variable is defined, regrtest
now disables randomization of tests.
@vstinner
Copy link
Member

vstinner commented Oct 1, 2023

Merged, thanks for the test @asottile.

@vstinner vstinner closed this as completed Oct 1, 2023
@encukou
Copy link
Member

encukou commented Oct 17, 2023

The feature breaks tests, see: #110932
If we are to maintain this case, it should probably have a buildbot.

@vstinner
Copy link
Member

If we are to maintain this case, it should probably have a buildbot.

I don't think that a whole buildbot is needed. Just additional tests.

Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@vstinner @Glyphack
pythongh-110164: regrtest disables random if SOURCE_DATE_EPOCH (pytho…
8cdd44f 
…n#110168)

If the SOURCE_DATE_EPOCH environment variable is defined, regrtest
now disables randomization of tests.
sir-xw pushed a commit to openkylin/python3.12 that referenced this issue Apr 18, 2025
Don't run the test suite in random order.
0a7262c 
Bug-Upstream: python/cpython#110164

Can be dropped in 3.13.

Gbp-Pq: Name test-no-random-order.diff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vstinner @encukou @asottile