Skip to content

test__xxinterpchannels leaks [21, 21, 21] references #110300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner opened this issue Oct 3, 2023 · 4 comments
Closed

test__xxinterpchannels leaks [21, 21, 21] references #110300

vstinner opened this issue Oct 3, 2023 · 4 comments
Assignees
Labels
tests Tests in the Lib/test dir topic-subinterpreters type-bug An unexpected behavior, bug, or error

Comments

@vstinner
Copy link
Member

vstinner commented Oct 3, 2023

./python -m test test__xxinterpchannels -R 3:3
(...)
test__xxinterpchannels leaked [21, 21, 21] references, sum=63

Regression introduced by: commit a8f5dab

commit a8f5dab58daca9f01ec3c6f8c85e53329251b05d
Author: Eric Snow <[email protected]>
Date:   Mon Oct 2 14:47:41 2023 -0600

    gh-76785: Module-level Fixes for test.support.interpreters (gh-110236)
    
    * add RecvChannel.close() and SendChannel.close()
    * make RecvChannel and SendChannel shareable
    * expose ChannelEmptyError and ChannelNotEmptyError

 Lib/test/support/interpreters.py  |  30 +++++--
 Lib/test/test_interpreters.py     |  16 ++++
 Modules/_xxinterpchannelsmodule.c | 185 +++++++++++++++++++++++++++++++++-----
 3 files changed, 206 insertions(+), 25 deletions(-)

Example of build: https://buildbot.python.org/all/#/builders/320/builds/855

cc @ericsnowcurrently

Linked PRs

@ericsnowcurrently
Copy link
Member

FWIW, test_interpreters has much worst leaks. They are due to _xxinterpchannels._register_end_types(). I'm going to temporarily drop that call and circle back to what's causing the leaks there.

@ericsnowcurrently
Copy link
Member

I've merged a temporary fix, but I still need to resolve the underlying issue.

@vstinner
Copy link
Member Author

vstinner commented Oct 4, 2023

./python -m test test__xxinterpchannels -R 3:3 no longer leaks, I close the issue.

@vstinner vstinner closed this as completed Oct 4, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Subinterpreters Oct 4, 2023
@ericsnowcurrently ericsnowcurrently added the type-bug An unexpected behavior, bug, or error label Feb 27, 2024
@ericsnowcurrently
Copy link
Member

FTR, I followed up on gh-110607.

Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir topic-subinterpreters type-bug An unexpected behavior, bug, or error
Projects
Status: Done
Development

No branches or pull requests

3 participants