Skip to content

venv/scripts/common/activate should unconditionally call hash -r #112431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
J-M0 opened this issue Nov 26, 2023 · 0 comments
Closed

venv/scripts/common/activate should unconditionally call hash -r #112431

J-M0 opened this issue Nov 26, 2023 · 0 comments
Labels
stdlib Python modules in the Lib dir topic-venv Related to the venv module type-bug An unexpected behavior, bug, or error

Comments

@J-M0
Copy link
Contributor

J-M0 commented Nov 26, 2023 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

The venv/scripts/common/activate script calls hash -r in two places to make sure the shell picks up the environment changes the script makes. Before that, it checks to see if the shell running the script is bash or zsh.

cpython/Lib/venv/scripts/common/activate

Lines 20 to 22 in fb202af

if [ -n "${BASH:-}" -o -n "${ZSH_VERSION:-}" ] ; then
hash -r 2> /dev/null
fi

cpython/Lib/venv/scripts/common/activate

Lines 75 to 77 in fb202af

if [ -n "${BASH:-}" -o -n "${ZSH_VERSION:-}" ] ; then
hash -r 2> /dev/null
fi

hash -r is specified by POSIX and is not exclusive to bash and zsh. This guard will prevent the script from calling hash -r in other #!/bin/sh-compatible shells like dash.

CPython versions tested on:

3.11, 3.12, 3.13

Operating systems tested on:

macOS, Windows

Linked PRs
@J-M0 J-M0 added the type-bug An unexpected behavior, bug, or error label Nov 26, 2023
@bedevere-app bedevere-app bot mentioned this issue Nov 26, 2023
Merged
@AlexWaygood AlexWaygood added stdlib Python modules in the Lib dir topic-venv Related to the venv module labels Nov 27, 2023
vsajip pushed a commit that referenced this issue Nov 28, 2023
@J-M0
gh-112431: Unconditionally call hash -r (GH-112432)
a194938 
The `activate` script calls `hash -r` in two places to make sure the shell picks
up the environment changes the script makes. Before that, it checks to
see if the shell running the script is bash or zsh.

`hash -r` is specified by POSIX and is not exclusive to bash and zsh.
This guard prevents the script from calling `hash -r` in other
`#!/bin/sh`-compatible shells like dash.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 28, 2023
@J-M0 @miss-islington
pythongh-112431: Unconditionally call hash -r (pythonGH-112432)
3fde462 
The `activate` script calls `hash -r` in two places to make sure the shell picks
up the environment changes the script makes. Before that, it checks to
see if the shell running the script is bash or zsh.

`hash -r` is specified by POSIX and is not exclusive to bash and zsh.
This guard prevents the script from calling `hash -r` in other
`GH-!/bin/sh`-compatible shells like dash.
(cherry picked from commit a194938)

Co-authored-by: James Morris <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Nov 28, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 28, 2023
@J-M0 @miss-islington
pythongh-112431: Unconditionally call hash -r (pythonGH-112432)
a3dd953 
The `activate` script calls `hash -r` in two places to make sure the shell picks
up the environment changes the script makes. Before that, it checks to
see if the shell running the script is bash or zsh.

`hash -r` is specified by POSIX and is not exclusive to bash and zsh.
This guard prevents the script from calling `hash -r` in other
`GH-!/bin/sh`-compatible shells like dash.
(cherry picked from commit a194938)

Co-authored-by: James Morris <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Nov 28, 2023
Merged
vsajip pushed a commit that referenced this issue Nov 28, 2023
@miss-islington @J-M0
[3.11] gh-112431: Unconditionally call hash -r (GH-112432) (GH-112492)
3c0d963 
gh-112431: Unconditionally call `hash -r` (GH-112432)

The `activate` script calls `hash -r` in two places to make sure the shell picks
up the environment changes the script makes. Before that, it checks to
see if the shell running the script is bash or zsh.

`hash -r` is specified by POSIX and is not exclusive to bash and zsh.
This guard prevents the script from calling `hash -r` in other
`GH-!/bin/sh`-compatible shells like dash.
(cherry picked from commit a194938)

Co-authored-by: James Morris <[email protected]>
vsajip pushed a commit that referenced this issue Nov 28, 2023
@miss-islington @J-M0
[3.12] gh-112431: Unconditionally call hash -r (GH-112432) (GH-112493)
49494c4 
gh-112431: Unconditionally call `hash -r` (GH-112432)

The `activate` script calls `hash -r` in two places to make sure the shell picks
up the environment changes the script makes. Before that, it checks to
see if the shell running the script is bash or zsh.

`hash -r` is specified by POSIX and is not exclusive to bash and zsh.
This guard prevents the script from calling `hash -r` in other
`GH-!/bin/sh`-compatible shells like dash.
(cherry picked from commit a194938)

Co-authored-by: James Morris <[email protected]>
@vsajip vsajip closed this as completed Nov 28, 2023
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@J-M0 @aisk
pythongh-112431: Unconditionally call hash -r (pythonGH-112432)
1897735 
The `activate` script calls `hash -r` in two places to make sure the shell picks
up the environment changes the script makes. Before that, it checks to
see if the shell running the script is bash or zsh.

`hash -r` is specified by POSIX and is not exclusive to bash and zsh.
This guard prevents the script from calling `hash -r` in other
`#!/bin/sh`-compatible shells like dash.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@J-M0 @Glyphack
pythongh-112431: Unconditionally call hash -r (pythonGH-112432)
38884a6 
The `activate` script calls `hash -r` in two places to make sure the shell picks
up the environment changes the script makes. Before that, it checks to
see if the shell running the script is bash or zsh.

`hash -r` is specified by POSIX and is not exclusive to bash and zsh.
This guard prevents the script from calling `hash -r` in other
`#!/bin/sh`-compatible shells like dash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir topic-venv Related to the venv module type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vsajip @J-M0 @AlexWaygood