Skip to content

Tests for path joining in test_pathlib are misplaced #112675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
barneygale opened this issue Dec 3, 2023 · 0 comments
Closed

Tests for path joining in test_pathlib are misplaced #112675

barneygale opened this issue Dec 3, 2023 · 0 comments
Labels
tests Tests in the Lib/test dir topic-pathlib

Comments

@barneygale
Copy link
Contributor

barneygale commented Dec 3, 2023 •
edited by bedevere-app bot
Loading

Pathlib originally implemented its own path joining algorithm with its own tests. Nowadays pathlib now calls through to os.path.join() (see #95450), but there's still a handful of tests for path joining remaining that are better suited to test_posixpath and test_ntpath.

Affects the test_drive_root_parts_common and test_drive_root_parts test methods.

Linked PRs
@barneygale barneygale added tests Tests in the Lib/test dir topic-pathlib labels Dec 3, 2023
barneygale added a commit to barneygale/cpython that referenced this issue Dec 3, 2023
@barneygale
pythonGH-112675: Move path joining tests into test_posixpath and `t…
002259f 
…est_ntpath`

In `test_pathlib`, the `check_drive_root_parts` test methods evaluated
both joining and parsing/normalisation of paths. This dates from a time
when pathlib implemented both functions itself, but nowadays path joining
is done with `posixpath.join()` and `ntpath.join()`.

This commit moves the joining-related test cases into `test_posixpath` and
`test_ntpath`.
@bedevere-app bedevere-app bot mentioned this issue Dec 3, 2023
Merged
barneygale added a commit that referenced this issue Dec 7, 2023
@barneygale
GH-112675: Move path joining tests into test_posixpath and `test_nt…
28b2b74 
…path` (#112676)

In `test_pathlib`, the `check_drive_root_parts` test methods evaluated
both joining and parsing/normalisation of paths. This dates from a time
when pathlib implemented both functions itself, but nowadays path joining
is done with `posixpath.join()` and `ntpath.join()`.

This commit moves the joining-related test cases into `test_posixpath` and
`test_ntpath`.
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@barneygale @aisk
pythonGH-112675: Move path joining tests into test_posixpath and `t…
8284da8 
…est_ntpath` (python#112676)

In `test_pathlib`, the `check_drive_root_parts` test methods evaluated
both joining and parsing/normalisation of paths. This dates from a time
when pathlib implemented both functions itself, but nowadays path joining
is done with `posixpath.join()` and `ntpath.join()`.

This commit moves the joining-related test cases into `test_posixpath` and
`test_ntpath`.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@barneygale @Glyphack
pythonGH-112675: Move path joining tests into test_posixpath and `t…
e35cb1f 
…est_ntpath` (python#112676)

In `test_pathlib`, the `check_drive_root_parts` test methods evaluated
both joining and parsing/normalisation of paths. This dates from a time
when pathlib implemented both functions itself, but nowadays path joining
is done with `posixpath.join()` and `ntpath.join()`.

This commit moves the joining-related test cases into `test_posixpath` and
`test_ntpath`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir topic-pathlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barneygale