Skip to content

CPython build failed with --enable-pystats after #118450 #121082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zheaoli opened this issue Jun 27, 2024 · 1 comment · Fixed by #121083
Closed

CPython build failed with --enable-pystats after #118450 #121082

Zheaoli opened this issue Jun 27, 2024 · 1 comment · Fixed by #121083
Labels
type-bug An unexpected behavior, bug, or error

Comments

@Zheaoli
Copy link
Contributor

Zheaoli commented Jun 27, 2024

Bug report

Bug description:

Python/specialize.c: In function ‘_Py_Specialize_ForIter’:
Python/specialize.c:2392:60: error: incompatible type for argument 1 of ‘_PySpecialization_ClassifyIterator’
 2392 |                         _PySpecialization_ClassifyIterator(iter));
      |                                                            ^~~~
      |                                                            |
      |                                                            _PyStackRef
Python/specialize.c:409:70: note: in definition of macro ‘SPECIALIZATION_FAIL’
  409 |         _Py_stats->opcode_stats[opcode].specialization.failure_kinds[kind]++; \
      |                                                                      ^~~~
Python/specialize.c:2290:47: note: expected ‘PyObject *’ {aka ‘struct _object *’} but argument is of type ‘_PyStackRef’
 2290 |  _PySpecialization_ClassifyIterator(PyObject *iter)
      |                                     ~~~~~~~~~~^~~~

Introduced after #118450

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

@Zheaoli
Copy link
Contributor Author

Zheaoli commented Jun 27, 2024

cc @Fidget-Spinner

Fidget-Spinner added a commit that referenced this issue Jun 27, 2024
…` arguments in configuration command after #118450 (#121083)



Signed-off-by: Manjusaka <[email protected]>
Co-authored-by: Ken Jin <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
…ystats` arguments in configuration command after python#118450 (python#121083)



Signed-off-by: Manjusaka <[email protected]>
Co-authored-by: Ken Jin <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
…ystats` arguments in configuration command after python#118450 (python#121083)



Signed-off-by: Manjusaka <[email protected]>
Co-authored-by: Ken Jin <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
…ystats` arguments in configuration command after python#118450 (python#121083)



Signed-off-by: Manjusaka <[email protected]>
Co-authored-by: Ken Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
1 participant