ctypes.Union & ctypes.Structure: common features should be tested on both types #124570
Assignees
Labels
Comments
|
It seems like the workload is quite heavy. I don't think it's necessary just to organize an almost stable and unchanging module. |
encukou
added a commit
to encukou/cpython
that referenced
this issue
Oct 4, 2024
- Move some Structure tests to test_structunion; use a common base test class + two subclasses to run them on Union too - Remove test_union for now as it's redundant Note: `test_simple_structs` & `test_simple_unions` are in the common file because they share `formats`.
|
But ctypes isn't stable and unchanging. In 3.14 the struct/union packing algorithm is replaced and moved to Python code. That on its own deserves better Union tests. |
encukou
added a commit
that referenced
this issue
Oct 10, 2024
- Move some Structure tests to test_structunion; use a common base test class + two subclasses to run them on Union too - Remove test_union for now as it's redundant Note: `test_simple_structs` & `test_simple_unions` are in the common file because they share `formats`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
Lib/test/test_ctypes/test_structure.pyis very long, butLib/test/test_ctypes/test_union.pyonly has recent additions.A lot of the Structure tests apply to Union as well, and should be run on both. My plan is:
Lib/test/test_ctypes/test_structunion.py, and use the “common base class + two subclasses” pattern used for tests of similar classesLib/test/test_ctypes/test_structure.pyLinked PRs
The text was updated successfully, but these errors were encountered: