Skip to content

JIT: Use pthread_jit_write_protect_np on macOS #126195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
diegorusso opened this issue Oct 30, 2024 · 1 comment
Open

JIT: Use pthread_jit_write_protect_np on macOS #126195

diegorusso opened this issue Oct 30, 2024 · 1 comment
Assignees
@diegorusso
Labels
OS-mac performance Performance or resource usage topic-JIT type-feature A feature request or enhancement

Comments

@diegorusso
Copy link
Contributor

diegorusso commented Oct 30, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

The proposal is an internal implementation of the JIT and it transparent to the user.

Has this already been discussed elsewhere?

I have already discussed this feature proposal on Discourse

Links to previous discussion of this feature:

Not on Discourse, I've had extensive discussion about this with @brandtbucher and created a prototype that we benchmarked using the faster-cpython infrastructure. The full results are here: https://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20241018-3.14.0a1+-f74cd79-JIT

On macOS on Apple Silicon there is an overall 1.4% speed improvement by replacing the mprotect with pthread_jit_write_protect_np.

Linked PRs
@diegorusso diegorusso added the type-feature A feature request or enhancement label Oct 30, 2024
@diegorusso diegorusso self-assigned this Oct 30, 2024
@diegorusso diegorusso added topic-JIT performance Performance or resource usage labels Oct 30, 2024
@Eclips4 Eclips4 added the OS-mac label Oct 30, 2024
diegorusso added a commit to diegorusso/cpython that referenced this issue Oct 30, 2024
@diegorusso
pythonGH-126195: Use pthread_jit_write_protect_np on macOS
df99209 
Replace mprotect with pthread_jit_write_protect_np
on MacOS Apple Silicon.
Improve JIT performance by ~1.4% on this platform.
diegorusso added a commit to diegorusso/cpython that referenced this issue Oct 30, 2024
@diegorusso
pythongh-126195: Use pthread_jit_write_protect_np on macOS
3e090bf 
Replace mprotect with pthread_jit_write_protect_np
on MacOS Apple Silicon.
Improve JIT performance by ~1.4% on this platform.
@bedevere-app bedevere-app bot mentioned this issue Oct 30, 2024
Merged
diegorusso added a commit to diegorusso/cpython that referenced this issue Nov 8, 2024
@diegorusso
pythongh-126195: Use pthread_jit_write_protect_np on macOS
71cef5e 
Replace mprotect with pthread_jit_write_protect_np
on MacOS Apple Silicon.
Improve JIT performance by ~1.4% on this platform.
brandtbucher pushed a commit that referenced this issue Nov 12, 2024
@diegorusso
GH-126195: Use M1 JIT memory protection APIs (GH-126196)
c45be8a
@brandtbucher
Copy link
Member

I'll leave this open in case we want to explore the pthread_jit_write_with_callback_np API: https://developer.apple.com/documentation/apple-silicon/porting-just-in-time-compilers-to-apple-silicon

picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@diegorusso @picnixz
pythonGH-126195: Use M1 JIT memory protection APIs (pythonGH-126196)
c10649f
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@diegorusso @ebonnal
pythonGH-126195: Use M1 JIT memory protection APIs (pythonGH-126196)
598e435
@ned-deily ned-deily mentioned this issue Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diegorusso diegorusso

Labels
OS-mac performance Performance or resource usage topic-JIT type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@diegorusso @brandtbucher @Eclips4