Moving _PyMem_RawStrdup to private API causes build failure

[clin1234]

#106320 causes build failure in marcelotduarte/cx_Freeze#2568 (comment)

What is the recommended replacement for the now private function?

[tomasr8]

Made private here: #107187

I think as a replacement you can do what the function is doing internally, that is, call PyMem_RawMalloc and memcpy:

cpython/Objects/obmalloc.c

Lines 1047 to 1057 in 52d552c

	_PyMem_RawStrdup(const char *str)
	{
	assert(str != NULL);
	size_t size = strlen(str) + 1;
	char *copy = PyMem_RawMalloc(size);
	if (copy == NULL) {
	return NULL;
	}
	memcpy(copy, str, size);
	return copy;
	}

[ZeroIntensity]

@vstinner Do you think it's worth adding a public variation of PyMem_Strdup and PyMem_RawStrdup?

[vstinner]

@ZeroIntensity:

@vstinner Do you think it's worth adding a public variation of PyMem_Strdup and PyMem_RawStrdup?

It's not worth it. Please don't add them.

There is a simple replacement for _PyMem_RawStrdup(): just use strdup() (with free()). If you really need/want to use PyMem_RawMalloc(), you can copy/paste the code that @tomasr8 gave.

[vstinner]

@clin1234: Would you be ok to close the issue? Or do you think that something else should be done? I'm not sure why you closed your cx_Freeze upstream PR.

[clin1234]

I made a separate pull request replacing the private function with strdup (marcelotduarte/cx_Freeze#2738)