Skip to content

clang-cl on Windows fails to compile after zlib-ng #131521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chris-eibl opened this issue Mar 20, 2025 · 1 comment
Closed

clang-cl on Windows fails to compile after zlib-ng #131521

chris-eibl opened this issue Mar 20, 2025 · 1 comment
Labels
build The build process and cross-build OS-windows

Comments

@chris-eibl
Copy link
Member

chris-eibl commented Mar 20, 2025 •
edited by bedevere-app bot
Loading

Since #131438, clang-cl fails to compile, see e.g. the tailcall Windows CI
https://github.com/python/cpython/actions/runs/13967899073/job/39102464260

Discussion started with @zooba in #131438 (comment).

Linked PRs
@zooba
Copy link
Member

zooba commented Mar 20, 2025

The config files for zlib-ng require CMake to generate, which we don't use as part of our build, so they were generated once for MSVC and added under the PC directory.

These will probably need tweaking to support clang-cl.

@bedevere-app bedevere-app bot mentioned this issue Mar 20, 2025
Merged
@encukou encukou added OS-windows build The build process and cross-build labels Mar 21, 2025
zooba pushed a commit that referenced this issue Mar 24, 2025
@chris-eibl
GH-131521: Uses correct build flags for zlib-ng on Windows (GH-131526)
d16f455 
Do not enable AdvancedVectorExtensions2 for all *.c files, so that the resulting binary can be executed on older CPUs, too. Also enable AdvancedVectorExtensions512 where necessary, and add the ClangCL flags required to enable vector extensions.
@chris-eibl chris-eibl changed the title clang-cl on Windows fails to compile after 131438 clang-cl on Windows fails to compile after zlib-ng Mar 25, 2025
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 1, 2025
@chris-eibl @diegorusso
pythonGH-131521: Uses correct build flags for zlib-ng on Windows (pyt…
64dac61 
…honGH-131526)

Do not enable AdvancedVectorExtensions2 for all *.c files, so that the resulting binary can be executed on older CPUs, too. Also enable AdvancedVectorExtensions512 where necessary, and add the ClangCL flags required to enable vector extensions.
seehwan pushed a commit to seehwan/cpython that referenced this issue Apr 16, 2025
@chris-eibl @seehwan80
pythonGH-131521: Uses correct build flags for zlib-ng on Windows (pyt…
70d1f4b 
…honGH-131526)

Do not enable AdvancedVectorExtensions2 for all *.c files, so that the resulting binary can be executed on older CPUs, too. Also enable AdvancedVectorExtensions512 where necessary, and add the ClangCL flags required to enable vector extensions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build OS-windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@encukou @zooba @chris-eibl