Skip to content

UBsan: Remove _Py_NO_SANITIZE_UNDEFINED #133157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
encukou opened this issue Apr 29, 2025 · 0 comments
Open

UBsan: Remove _Py_NO_SANITIZE_UNDEFINED #133157

encukou opened this issue Apr 29, 2025 · 0 comments
Assignees
@picnixz
Labels
extension-modules C modules in the Modules dir interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API type-bug An unexpected behavior, bug, or error

Comments

@encukou
Copy link
Member

encukou commented Apr 29, 2025 •
edited by bedevere-app bot
Loading

Bug report

Split out from the #111178 monster-issue:

We use the macro _Py_NO_SANITIZE_UNDEFINED to disable the UB sanitizer in some hard-to-fix cases, so that we can get a stable, regression-monitoring checker sooner.
To fully fix UBsan failures, we should get rid of the macro.
At least outside test functions.

Linked PRs
@encukou encukou added topic-C-API type-bug An unexpected behavior, bug, or error labels Apr 29, 2025
@encukou encukou mentioned this issue Apr 29, 2025
Closed
@picnixz picnixz self-assigned this May 15, 2025
This was referenced May 15, 2025
Merged
Merged
Closed
@picnixz picnixz added interpreter-core (Objects, Python, Grammar, and Parser dirs) extension-modules C modules in the Modules dir labels May 15, 2025
picnixz added a commit that referenced this issue May 18, 2025
@picnixz
gh-133157: remove usage of _Py_NO_SANITIZE_UNDEFINED in `faulthandl…
0a160bf 
…er` (#134047)

In `faulthandler_sigfpe()`, instead of using 1/0 arithmetic, we explicitly raise SIGFPE.
We also remove `faulthandler._read_null()` since reading from NULL is an undefined
behavior and `faulthandler` should not check for low-level C undefined behaviors.
pablogsal pushed a commit that referenced this issue Jun 10, 2025
@picnixz
gh-133157: remove usage of _Py_NO_SANITIZE_UNDEFINED in `Parser/peg…
754e7c9 
…en.c` (#134048)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 10, 2025
@picnixz @miss-islington
pythongh-133157: remove usage of _Py_NO_SANITIZE_UNDEFINED in `Pars…
b9a80b5 
…er/pegen.c` (pythonGH-134048)

(cherry picked from commit 754e7c9)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jun 10, 2025
Merged
pablogsal pushed a commit that referenced this issue Jun 10, 2025
@miss-islington @picnixz
[3.14] gh-133157: remove usage of _Py_NO_SANITIZE_UNDEFINED in `Par…
904685f 
…ser/pegen.c` (GH-134048) (#135320)

gh-133157: remove usage of `_Py_NO_SANITIZE_UNDEFINED` in `Parser/pegen.c` (GH-134048)
(cherry picked from commit 754e7c9)

Co-authored-by: Bénédikt Tran <[email protected]>
picnixz added a commit to picnixz/cpython that referenced this issue Jun 10, 2025
@picnixz
[3.13] pythongh-133157: remove usage of _Py_NO_SANITIZE_UNDEFINED i…
dc805f2 
…n `Parser/pegen.c` (pythonGH-134048)

(cherry picked from commit 754e7c9)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jun 10, 2025
Merged
picnixz added a commit that referenced this issue Jun 10, 2025
@picnixz
[3.13] gh-133157: fix UBSan failures in Parser/pegen.c (GH-134048) (#…
dd7ffdb 
…135334)

[3.13] gh-133157: fix UBSan failures in `Parser/pegen.c` (GH-134048)
(cherry picked from commit 754e7c9)
encukou added a commit to encukou/cpython that referenced this issue Jun 10, 2025
@encukou @picnixz
pythongh-133157: remove usage of _Py_NO_SANITIZE_UNDEFINED in `pyex…
d0dc245 
…pat`

Co-Authored-By: Bénédikt Tran <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jun 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@picnixz picnixz

Labels
extension-modules C modules in the Modules dir interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@encukou @picnixz