Skip to content

nt._supports_virtual_terminal missing guard for console io #133537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maxbachmann opened this issue May 6, 2025 · 0 comments
Closed

nt._supports_virtual_terminal missing guard for console io #133537

maxbachmann opened this issue May 6, 2025 · 0 comments
Labels
build The build process and cross-build interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows type-bug An unexpected behavior, bug, or error

Comments

@maxbachmann
Copy link
Contributor

maxbachmann commented May 6, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

nt._supports_virtual_terminal uses windows console io calls even when they aren't available in the windows app partition. This leads to compilation failures

CPython versions tested on:

3.13

Operating systems tested on:

No response

Linked PRs
@maxbachmann maxbachmann added the type-bug An unexpected behavior, bug, or error label May 6, 2025
@bedevere-app bedevere-app bot mentioned this issue May 6, 2025
Merged
@chris-eibl chris-eibl added OS-windows interpreter-core (Objects, Python, Grammar, and Parser dirs) build The build process and cross-build labels May 7, 2025
zooba pushed a commit that referenced this issue May 7, 2025
@maxbachmann
gh-133537: Avoid using console I/O in WinAPI partitions that don't su…
1460cce 
…pport it (GH-133538)
@zooba zooba closed this as completed May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zooba @maxbachmann @chris-eibl