Skip to content

curses: Descripton of KEY_NPAGE and KEY_PPAGE inverted #70866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RobertBachmann mannequin opened this issue Mar 31, 2016 · 4 comments
Closed

curses: Descripton of KEY_NPAGE and KEY_PPAGE inverted #70866

RobertBachmann mannequin opened this issue Mar 31, 2016 · 4 comments
Labels
docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@RobertBachmann
Copy link
Mannequin

RobertBachmann mannequin commented Mar 31, 2016

BPO 26679
Nosy @berkerpeksag
Files
  • curses.patch
  • issue26679.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2016-04-02.01:50:38.645>
    created_at = <Date 2016-03-31.19:33:42.667>
    labels = ['type-bug', 'docs']
    title = 'curses: Descripton of KEY_NPAGE and KEY_PPAGE inverted'
    updated_at = <Date 2016-04-02.01:50:38.644>
    user = 'https://bugs.python.org/RobertBachmann'

    bugs.python.org fields:

    activity = <Date 2016-04-02.01:50:38.644>
    actor = 'berker.peksag'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2016-04-02.01:50:38.645>
    closer = 'berker.peksag'
    components = ['Documentation']
    creation = <Date 2016-03-31.19:33:42.667>
    creator = 'Robert Bachmann'
    dependencies = []
    files = ['42334', '42344']
    hgrepos = []
    issue_num = 26679
    keywords = ['patch']
    message_count = 4.0
    messages = ['262701', '262745', '262783', '262784']
    nosy_count = 5.0
    nosy_names = ['SilentGhost', 'docs@python', 'python-dev', 'berker.peksag', 'Robert Bachmann']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue26679'
    versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']

    @RobertBachmann
    Copy link
    Mannequin Author

    RobertBachmann mannequin commented Mar 31, 2016

    The table on <https://docs.python.org/3/library/curses.html\>
    lists:


    Page Up KEY_NPAGE
    Page Down KEY_PPAGE


    it should be vice versa.

    @RobertBachmann RobertBachmann mannequin added the type-feature A feature request or enhancement label Mar 31, 2016
    @RobertBachmann RobertBachmann mannequin added the docs Documentation in the Doc dir label Mar 31, 2016
    @SilentGhost
    Copy link
    Mannequin

    SilentGhost mannequin commented Apr 1, 2016

    Here is the patch.

    @SilentGhost SilentGhost mannequin added type-bug An unexpected behavior, bug, or error and removed type-feature A feature request or enhancement labels Apr 1, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 2, 2016

    New changeset f41d3321007f by Berker Peksag in branch '3.5':
    Issue bpo-26679: Fix description of KEY_PPAGE and KEY_NPAGE constants
    https://hg.python.org/cpython/rev/f41d3321007f

    New changeset 23d986228c6b by Berker Peksag in branch 'default':
    Issue bpo-26679: Fix description of KEY_PPAGE and KEY_NPAGE constants
    https://hg.python.org/cpython/rev/23d986228c6b

    @berkerpeksag
    Copy link
    Member

    Thanks, Robert and SilentGhost.

    I verified the patch with the following script:

    import curses
    
    
    def main(stdscr):
        while True:
            c = stdscr.getch()
            if c == curses.KEY_PPAGE:
                stdscr.addstr('Page Up')
            elif c == curses.KEY_NPAGE:
                stdscr.addstr('Page Down')
            else:
                stdscr.addstr('Another key')
    
    curses.wrapper(main)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant