Makefile.pre.in: commoninstall: reformat

[dilyanpalauzov]

BPO	31188

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2017-08-12.17:58:52.659>
labels = ['easy', 'type-bug', '3.9', '3.10', '3.11', 'build']
title = 'Makefile.pre.in: commoninstall: reformat'
updated_at = <Date 2022-01-04.22:33:51.731>
user = 'https://bugs.python.org/dilyanpalauzov'

bugs.python.org fields:

activity = <Date 2022-01-04.22:33:51.731>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Build']
creation = <Date 2017-08-12.17:58:52.659>
creator = 'dilyan.palauzov'
dependencies = []
files = []
hgrepos = []
issue_num = 31188
keywords = ['easy']
message_count = 1.0
messages = ['300204']
nosy_count = 1.0
nosy_names = ['dilyan.palauzov']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue31188'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

Linked PRs

• gh-75371: reformat Makefile.pre.in to accommodate for empty FRAMEWORKALTINSTALLLAST #107035
• [3.12] gh-75371: reformat Makefile.pre.in to accommodate for empty FRAMEWORKALTINSTALLLAST (GH-107035) #107049
• [3.11] gh-75371: reformat Makefile.pre.in to accommodate for empty FRAMEWORKALTINSTALLLAST (GH-107035) #107050

[dilyanpalauzov]

When @FRAMEWORKALTINSTALLLAST@ expands to "", the last line of recipe commoninstall in the resulting Makefile consists solely of two tabs, for which emacs complains as "suspicious line".

diff --git a/Makefile.pre.in b/Makefile.pre.in
--- a/Makefile.pre.in
+++ b/Makefile.pre.in
@@ -1069,8 +1069,7 @@ altinstall: commoninstall
 
 commoninstall:  @FRAMEWORKALTINSTALLFIRST@ \
                altbininstall libinstall inclinstall libainstall \
-               sharedinstall oldsharedinstall altmaninstall \
-               @FRAMEWORKALTINSTALLLAST@
+               sharedinstall oldsharedinstall altmaninstall @FRAMEWORKALTINSTALLLAST@
 
 # Install shared libraries enabled by Setup
 DESTDIRS=      $(exec_prefix) $(LIBDIR) $(BINLIBDEST) $(DESTSHARED)