Skip to content

Update IDLE's credits #83270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taleinat opened this issue Dec 18, 2019 · 8 comments · Fixed by #95528, #95560 or #95559
Closed

Update IDLE's credits #83270

taleinat opened this issue Dec 18, 2019 · 8 comments · Fixed by #95528, #95560 or #95559
Assignees
Labels
3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes easy topic-IDLE

Comments

@taleinat
Copy link
Contributor

BPO 39089
Nosy @terryjreedy, @taleinat

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = None
created_at = <Date 2019-12-18.17:44:49.810>
labels = ['expert-IDLE', '3.7', '3.8', '3.9']
title = "Update IDLE's credits"
updated_at = <Date 2020-04-24.20:45:04.897>
user = 'https://github.com/taleinat'

bugs.python.org fields:

activity = <Date 2020-04-24.20:45:04.897>
actor = 'taleinat'
assignee = 'terry.reedy'
closed = False
closed_date = None
closer = None
components = ['IDLE']
creation = <Date 2019-12-18.17:44:49.810>
creator = 'taleinat'
dependencies = []
files = []
hgrepos = []
issue_num = 39089
keywords = []
message_count = 3.0
messages = ['358636', '365296', '367222']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'taleinat']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue39089'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

@taleinat
Copy link
Contributor Author

The "Credits" document in the "About" dialog could use some updating. It fails to mention Saimadhav Heblikar's important work during GSoC 2014 as well as Terry J. Reedy's tireless work over the past few years which has helped keep IDLE in working order and the codebase in reasonable shape given its age.

@taleinat taleinat added 3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes labels Dec 18, 2019
@taleinat taleinat added topic-IDLE 3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes labels Dec 18, 2019
@terryjreedy
Copy link
Member

I have thought about everything from deleting the file to a detailed update. If we keep it, anything would be an improvement. Perhap something in the middle, starting in 2013. I just decided I don't need be be responsible for anything earlier, even this I actually started in Fall 2010.

2013 Roger Serwy (and perhaps GSOC Phil Webster -- I need to look more at News log.)
2014 Saimadhav Heblikar
2015 Mark Roseman
2017 Louie Lu, Cheryl Sabella, Serhiy Storchaka, the latter two to date.
201?, 2019 Tal Einat

Can you make a suggested addition?

@taleinat
Copy link
Contributor Author

Looks pretty good to me. I've been working on IDLE since... 2003/2004, beginning with a private fork of IDLE-fork. I began actually contributing to the main CPython version of IDLE in 2005.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 1, 2022
@erlend-aasland erlend-aasland moved this to In Progress in IDLE Issues Aug 1, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 2, 2022
Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 698fa8b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 2, 2022
Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 698fa8b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
terryjreedy added a commit that referenced this issue Aug 2, 2022
miss-islington added a commit that referenced this issue Aug 2, 2022
Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 698fa8b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@terryjreedy
Copy link
Member

Erlend's PR includes info above and add a generic 'look at logs' comment. If/when I or someone decides someone else should be added, after looking through logs, a no-issue, no-blurb PR should be fine.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Aug 2, 2022

If/when I or someone decides someone else should be added, after looking through logs, a no-issue, no-blurb PR should be fine.

+1

Let's close this when the backport is merged. UPDATE: I linked the backport PR; this issue should close automatically when Pablo unlocks the 3.10 branch and that PR is merged.

@erlend-aasland erlend-aasland linked a pull request Aug 2, 2022 that will close this issue
erlend-aasland added a commit that referenced this issue Aug 2, 2022
Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 698fa8b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Repository owner moved this from In Progress to Done in IDLE Issues Aug 2, 2022
@erlend-aasland
Copy link
Contributor

I linked the backport PR; this issue should close automatically when Pablo unlocks the 3.10 branch and that PR is merged.

Well, it didn't. I don't know why.

@terryjreedy
Copy link
Member

terryjreedy commented Aug 2, 2022

The bots are not perfect. This is why the issue should not be closed when the first PR is merged to main. Anyway, thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment