Skip to content

_freeze_module on Windows can be built faster with no optimization #90281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neonene mannequin opened this issue Dec 18, 2021 · 2 comments
Closed

_freeze_module on Windows can be built faster with no optimization #90281

neonene mannequin opened this issue Dec 18, 2021 · 2 comments
Labels
3.11 only security fixes build The build process and cross-build OS-windows performance Performance or resource usage

Comments

@neonene
Copy link
Mannequin

neonene mannequin commented Dec 18, 2021

BPO 46123
Nosy @pfmoore, @tjguk, @zware, @zooba, @neonene
PRs
  • bpo-46123: Disable optimizations for _freeze_module.exe on MSVC for faster building #30181
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-12-19.14:55:29.587>
    created_at = <Date 2021-12-18.11:50:48.124>
    labels = ['3.11', 'build', 'OS-windows', 'performance']
    title = '_freeze_module on Windows can be built faster with no optimization'
    updated_at = <Date 2021-12-19.14:55:29.586>
    user = 'https://github.com/neonene'

    bugs.python.org fields:

    activity = <Date 2021-12-19.14:55:29.586>
    actor = 'steve.dower'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-12-19.14:55:29.587>
    closer = 'steve.dower'
    components = ['Build', 'Windows']
    creation = <Date 2021-12-18.11:50:48.124>
    creator = 'neonene'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 46123
    keywords = ['patch']
    message_count = 2.0
    messages = ['408841', '408904']
    nosy_count = 5.0
    nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'neonene']
    pr_nums = ['30181']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'performance'
    url = 'https://bugs.python.org/issue46123'
    versions = ['Python 3.11']

    @neonene
    Copy link
    Mannequin Author

    neonene mannequin commented Dec 18, 2021

    In Makefile.pre.in, LTO is disabled when building _freeze_module. MSVC can also cut the build time of _freeze_module.exe in half without the optimization.

    @neonene neonene mannequin added 3.11 only security fixes build The build process and cross-build OS-windows performance Performance or resource usage labels Dec 18, 2021
    @zooba
    Copy link
    Member

    zooba commented Dec 19, 2021

    New changeset 0b582a4 by neonene in branch 'main':
    bpo-46123: Disable optimizations for _freeze_module.exe on MSVC for faster building (GH-30181)
    0b582a4

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes build The build process and cross-build OS-windows performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant