Skip to content

Do not build the freeze module twice in case of Windows PGO builds #130419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chris-eibl opened this issue Feb 21, 2025 · 0 comments
Closed

Do not build the freeze module twice in case of Windows PGO builds #130419

chris-eibl opened this issue Feb 21, 2025 · 0 comments
Labels
build The build process and cross-build OS-windows type-feature A feature request or enhancement

Comments

@chris-eibl
Copy link
Member

chris-eibl commented Feb 21, 2025

Feature or enhancement

Proposal:

From #129907 (comment)

Avoiding the rebuild of _freeze_module and the refreezing would be nice, but it's not a huge deal (a few seconds in a ~hour long release process). Don't mix it in with this PR.

This is another low hanging fruit to make the Windows PGO build slightly faster (like #90281 did) by not building the _freeze_module again in the PGUpdate phase.

This will decrease both the MSVC and the clang-cl PGO build time (#130090).

In case of clang-cl, this saves me up to 40 seconds on my machine. Please see #131005 Details pgupdate build times for more numbers

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build OS-windows type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants