-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-98239: Document that inspect.getsource()
can raise TypeError
#101689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AlexWaygood this is quite a simple change, but it is stuck. Can you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just two small suggestions to minimise the diff and keep the additions consistent with the immediate surrounding text:
Co-authored-by: Alex Waygood <[email protected]>
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
…ror` (pythonGH-101689) (cherry picked from commit b613208) Co-authored-by: Nikita Sobolev <[email protected]>
GH-102969 is a backport of this pull request to the 3.11 branch. |
…ror` (pythonGH-101689) (cherry picked from commit b613208) Co-authored-by: Nikita Sobolev <[email protected]>
GH-102970 is a backport of this pull request to the 3.10 branch. |
…H-101689) (cherry picked from commit b613208) Co-authored-by: Nikita Sobolev <[email protected]>
…H-101689) (cherry picked from commit b613208) Co-authored-by: Nikita Sobolev <[email protected]>
Now all
inspect.getsourcefile
,inspect.getsourcelines
, andinspect.getsource
mention theTypeError
case.cc @ericvsmith