Skip to content

gh-102204: Fix endianness issue in AIX #102206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

gh-102204: Fix endianness issue in AIX #102206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5b132a
pythongh-102204: Fix endianness issue in AIX
ayappanec Feb 24, 2023
d73e44f
Add NEWS entry
ayappanec Feb 24, 2023
43871c1
Merge branch 'main' into gh-102204
ayappanec Feb 27, 2023
388d77b
Merge branch 'main' into gh-102204
ayappanec Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2023-02-24-03-54-39.gh-issue-102204.EV1GPP.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
AIX doesn't have ``__BYTE_ORDER__`` defined when XLC compiler is used which
breaks ``_hacl`` module build. So define _AIX in the generic big-endian
fallback code.
5 changes: 3 additions & 2 deletions Modules/_hacl/include/krml/lowstar_endianness.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,9 @@
# define be64toh(x) __builtin_bswap64(x)
# define le64toh(x) (x)

/* ... generic big-endian fallback code */
#elif defined(__BYTE_ORDER__) && __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
/* ... generic big-endian fallback code
... AIX doesn't have __BYTE_ORDER__ (with XLC compiler) & is always big-endian */
#elif (defined(__BYTE_ORDER__) && __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__) || defined(_AIX)

/* byte swapping code inspired by:
* https://github.com/rweather/arduinolibs/blob/master/libraries/Crypto/utility/EndianUtil.h
Expand Down