[WIP] bpo-35134: Create Include/pycapi/ subdirectory #10285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create Include/pycapi/ subdirectory * "make install" now creates $prefix/include/pycapi and copy Include/pycapi/* to $prefix/include/pycapi * Create Include/pycapi/pycapi_objimpl.h: move objimpl.h code surrounded by #ifndef Py_LIMITED_API to pycapi_objimpl.h. * objimpl.h includes pycapi/pycapi_objimpl.h
vstinner
requested review from
ncoghlan,
ericsnowcurrently and
serhiy-storchaka
vstinner
commented
Nov 1, 2018
| #ifdef __cplusplus | ||
| extern "C" { | ||
| #endif | ||
|
|
There was a problem hiding this comment.
I wanted to add:
#ifdef Py_LIMITED_API
# error "Py_LIMITED_API must not be defined to include this header"
#endif
But this header should be include if Py_LIMITED_API is defined with a value.
There was a problem hiding this comment.
If you don't move PyObject_Calloc (because it's in the stable ABI in 3.5+), then you can add that guard to the unstable ABI header.
| @@ -95,24 +95,9 @@ PyObject_{New, NewVar, Del}. | |||
| the raw memory. | |||
| */ | |||
| PyAPI_FUNC(void *) PyObject_Malloc(size_t size); | |||
| #if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= 0x03050000 | |||
| PyAPI_FUNC(void *) PyObject_Calloc(size_t nelem, size_t elsize); | |||
There was a problem hiding this comment.
It is in the stable API (since version 3.5). It should not be moved.
The same is for other functions, added to the stable API after 3.2.
|
I abandon this PR: moving PyObject_Calloc() was wrong, and "pycapi" name is too generic: I created a new PR #10624. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include/pycapi/* to $prefix/include/pycapi
surrounded by #ifndef Py_LIMITED_API to pycapi_objimpl.h.
https://bugs.python.org/issue35134