Skip to content

gh-103025: fix ctypes doc issues #103026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

peterjpxie
Copy link
Contributor

@peterjpxie peterjpxie commented Mar 25, 2023

1/ Rectify typo 'varadic' functions to 'variadic'.

2/ Fix doctest directive mistake.

@peterjpxie
Copy link
Contributor Author

@CAM-Gerlach pls. kindly review this PR if all checks pass. Thanks!

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not Cam, but looks good to me — thanks!

@AlexWaygood AlexWaygood added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 25, 2023
@AlexWaygood AlexWaygood merged commit 0708437 into python:main Mar 25, 2023
@miss-islington
Copy link
Contributor

Thanks @peterjpxie for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2023
(cherry picked from commit 0708437)

Co-authored-by: Peter Jiping Xie <[email protected]>
@bedevere-bot
Copy link

GH-103029 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2023
(cherry picked from commit 0708437)

Co-authored-by: Peter Jiping Xie <[email protected]>
@bedevere-bot
Copy link

GH-103030 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 25, 2023
@bedevere-bot

This comment was marked as duplicate.

@bedevere-bot

This comment was marked as duplicate.

AlexWaygood pushed a commit that referenced this pull request Mar 25, 2023
* gh-103025: fix two ctypes doc issues  (GH-103026)
(cherry picked from commit 0708437)
AlexWaygood pushed a commit that referenced this pull request Mar 25, 2023
* gh-103025: fix two ctypes doc issues  (GH-103026)
(cherry picked from commit 0708437)

Co-authored-by: Peter Jiping Xie <[email protected]>
@peterjpxie peterjpxie deleted the fix-ctypes-doc-issues branch March 25, 2023 11:02
@CAM-Gerlach
Copy link
Member

Thanks @peterjpxie ! Just to note for the record, the context of this is the DIscourse thread here , where the OP originally raised the issue and suggested they go ahead with a PR to fix it.

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants