Skip to content

Add missing variables to bytecodes.c #103153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

brettcannon
Copy link
Member

The code works without this change, but it does cause C tooling to complain less about undeclared variables.

The code works without this change, but it does cause C tooling to complain less about undeclared variables.
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I’ve fallen behind adding these.

Note that there are three ways of adding names, all equivalent — static globals, arguments, or locals.

@brettcannon
Copy link
Member Author

Note that there are three ways of adding names, all equivalent — static globals, arguments, or locals.

When I noticed the static globals I went to add them, but then I got some odd errors, so I just left what I had already typed out.

@gvanrossum
Copy link
Member

Sure. This doesn’t matter hugely, it just reduces the red wiggles. If we had a VS Code extension for this type of file we wouldn’t need these at all.

Also the second commit demonstrates why I am no fan of the ‘#line’ directives. But alla. LG.

@brettcannon brettcannon merged commit d97aef8 into python:main Mar 31, 2023
@brettcannon brettcannon deleted the bytecodes-missing-vars branch March 31, 2023 21:23
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
The code works without this change, but it does cause C tooling to complain less about undeclared variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants