gh-103225: Fixed zero lineno issue for pdb

[gaogaotiantian]

According to #103225, inspect.getsourcelines() returns wrong line number. Fixing it it inspect will take extra discussion so we fixed it in pdb for now. If in the future this got fixed in inspect we can take the fix away.

Co-authored-by: Artem Mukhin [email protected]

• Issue: pdb shows wrong line numbers for modules #103225

[artemmukhin]

Sure! Thank you for extracting the workaround and the test for pdb into a separate PR.

Regarding adding co-authors, this article might be helpful. But that is fine anyway 🙂

[gaogaotiantian]

Sure! Thank you for extracting the workaround and the test for pdb into a separate PR.

Regarding adding co-authors, this article might be helpful. But that is fine anyway 🙂

Thanks! That's helpful!

[gaogaotiantian]

@iritkatriel could you take a look at this fix which originally was done in inspect #103226

[iritkatriel]

I've added the "co-authored by" line to the first comment.

[gaogaotiantian]

I've added the "co-authored by" line to the first comment.

I redid the commit with co-authored-by so @ortem is showing as the co-author in the commit now.

[iritkatriel]

I’m not sure that would work, because we squash the commits when merging and typically remove the individual commit messages. It does get picked up from the description of the PR though.

[gaogaotiantian]

Hmm, interesting to know that. Next time I'll do it in the PR.

[iritkatriel]

Hmm, interesting to know that. Next time I'll do it in the PR.

Actually I think more accurately - GitHub probably picks up the coauthor from the commit message, but the person who merges typically deletes all the individual commit messages, and is more likely to notice the "co-authored by" in the main message and not erase it.

[gaogaotiantian]

@iritkatriel should we port this back to 3.11?

[iritkatriel]

@iritkatriel should we port this back to 3.11?

We could, if this bug is there as well. Could you check to make sure, and then make a PR for 3.11?

[bedevere-bot]

GH-104262 is a backport of this pull request to the 3.11 branch.

[gaogaotiantian]

@iritkatriel should we port this back to 3.11?

We could, if this bug is there as well. Could you check to make sure, and then make a PR for 3.11?

Confirmed that 3.11 has this issue as well, PR was made.