-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-95299: Rework test_cppext.py to not invoke setup.py directly #103316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
41c5a66
635492e
63d691c
d79d6a6
7c40f3c
f6c4024
dd16041
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,10 @@ | ||
| # gh-91321: Build a basic C++ test extension to check that the Python C API is | ||
| # compatible with C++ and does not emit C++ compiler warnings. | ||
| import os.path | ||
| try: | ||
| import ssl | ||
| except ImportError: | ||
| ssl = None | ||
| import sys | ||
| import unittest | ||
| import subprocess | ||
|
|
@@ -11,8 +15,7 @@ | |
|
|
||
| MS_WINDOWS = (sys.platform == 'win32') | ||
|
|
||
|
|
||
| SETUP_TESTCPPEXT = support.findfile('setup_testcppext.py') | ||
| PKG_CPPEXTDATA = os.path.join(os.path.dirname(__file__), "cppextdata") | ||
|
|
||
|
|
||
| @support.requires_subprocess() | ||
|
|
@@ -31,6 +34,8 @@ def test_build_cpp03(self): | |
| @unittest.skipIf( | ||
| '-fsanitize' in (sysconfig.get_config_var('PY_CFLAGS') or ''), | ||
| 'test does not work with analyzing builds') | ||
| # the test uses pip which needs a TLS connection to PyPI | ||
|
||
| @unittest.skipIf(ssl is None, 'No ssl module') | ||
| # the test uses venv+pip: skip if it's not available | ||
| @support.requires_venv_with_pip() | ||
| def check_build(self, std_cpp03, extension_name): | ||
|
|
@@ -59,11 +64,15 @@ def _check_build(self, std_cpp03, extension_name): | |
| python = os.path.join(venv_dir, 'bin', python_exe) | ||
|
|
||
| def run_cmd(operation, cmd): | ||
| env = os.environ.copy() | ||
| env['CPYTHON_TEST_CPP_STD'] = 'c++03' if std_cpp03 else 'c++11' | ||
| env['CPYTHON_TEST_EXT_NAME'] = extension_name | ||
| if verbose: | ||
| print('Run:', ' '.join(cmd)) | ||
| subprocess.run(cmd, check=True) | ||
| subprocess.run(cmd, check=True, env=env) | ||
| else: | ||
| proc = subprocess.run(cmd, | ||
| env=env, | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.STDOUT, | ||
| text=True) | ||
|
|
@@ -72,16 +81,9 @@ def run_cmd(operation, cmd): | |
| self.fail( | ||
| f"{operation} failed with exit code {proc.returncode}") | ||
|
|
||
| # Build the C++ extension | ||
| cmd = [python, '-X', 'dev', | ||
| SETUP_TESTCPPEXT, 'build_ext', '--verbose'] | ||
| if std_cpp03: | ||
| cmd.append('-std=c++03') | ||
| run_cmd('Build', cmd) | ||
|
|
||
| # Install the C++ extension | ||
| # Build and install the C++ extension | ||
| cmd = [python, '-X', 'dev', | ||
| SETUP_TESTCPPEXT, 'install'] | ||
| '-m', 'pip', 'install', PKG_CPPEXTDATA] | ||
| run_cmd('Install', cmd) | ||
|
|
||
| # Do a reference run. Until we test that running python | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.