Skip to content

gh-103438: Don't define CTYPES_PASS_BY_REF_HACK on aarch64 or riscv64 #103439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

gh-103438: Don't define CTYPES_PASS_BY_REF_HACK on aarch64 or riscv64 #103439

wants to merge 1 commit into from

Conversation

andreas-schwab
Copy link
Contributor

@andreas-schwab andreas-schwab commented Apr 11, 2023

This was a workaround for a bug in libffi that has been fixed.

@ghost
Copy link

ghost commented Apr 11, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a comment on test_pass_by_value linking to GH-103438 and noting that it's possible the user is using an older libffi if the test is failing.

We also need a news entry documenting this change.

@ronaldoussoren
Copy link
Contributor

We should probably add a comment on test_pass_by_value linking to GH-103438 and noting that it's possible the user is using an older libffi if the test is failing.

We also need a news entry documenting this change.

"And older libffi" is also the version included with macOS (the current SDK headers claim to be 3.4rc1). If I understand correctly unconditionally removing this workaround would therefore break macOS builds that use the system libffi, including our own installers.

This was a workaround for a bug in libffi that has been fixed.
@andreas-schwab andreas-schwab closed this by deleting the head repository Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants