gh-103668: Run pyugrade on idlelib #103671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryjreedy
reviewed
Apr 22, 2023
There was a problem hiding this comment.
Thanks for doing this; saves me installing pyupgrade. Is this with 3.11 option? Changes only involve super, open, f-string, .format(2), and 2 others once each. So not nearly as hard to review as I expected. I will apply my suggestions, recheck after CI, and presumably merge and backport.
Yes
Yes, looks like all other legacy code was updated already / not used. |
|
Thanks @sobolevn for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 23, 2023
--------- Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit bd2dca0) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-103730 is a backport of this pull request to the 3.11 branch. |
terryjreedy
pushed a commit
that referenced
this pull request
Apr 24, 2023
--------- (cherry picked from commit bd2dca0) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Terry Jan Reedy [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a demo, please feel free to close.