Skip to content

Re-enable commented-out test in test_generators.py #104130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2023
Merged

Re-enable commented-out test in test_generators.py #104130

merged 1 commit into from
May 7, 2023

Conversation

ymki4360
Copy link
Contributor

@ymki4360 ymki4360 commented May 3, 2023

test is commented out in test_generators.py, although it works as expected

# Pegen does not produce this error message yet
# >>> def f(): x = yield = y
# Traceback (most recent call last):
#   ...
# SyntaxError: assignment to yield expression not possible

I am not familiar with github, sorry if something is wrong

@ghost
Copy link

ghost commented May 3, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 3, 2023
@AlexWaygood AlexWaygood changed the title gh-NNNNN: reenables test in test_generators.py Re-enable commented-out test in test_generators.py May 3, 2023
AlexWaygood
AlexWaygood approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AlexWaygood AlexWaygood requested a review from pablogsal May 3, 2023 11:46
@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label May 3, 2023
@AlexWaygood AlexWaygood self-assigned this May 4, 2023
@kumaraditya303 kumaraditya303 merged commit 4729383 into python:main May 7, 2023
@miss-islington
Copy link
Contributor

Thanks @ymki4360 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-104261 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 7, 2023
@ymki4360 @miss-islington
Re-enable commented-out test in test_generators.py (pythonGH-104130)
67d52ae 
(cherry picked from commit 4729383)

Co-authored-by: ymki4360 <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 7, 2023
kumaraditya303 pushed a commit that referenced this pull request May 7, 2023
@miss-islington @ymki4360
[3.11] Re-enable commented-out test in test_generators.py (GH-104130) (…
c5dafea 
…#104261)

Re-enable commented-out test in test_generators.py (GH-104130)
(cherry picked from commit 4729383)

Co-authored-by: ymki4360 <[email protected]>
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@ymki4360 @jbower-fb
Re-enable commented-out test in test_generators.py (python#104130)
7e11146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

@AlexWaygood AlexWaygood

Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ymki4360 @bedevere-bot @miss-islington @kumaraditya303 @AlexWaygood