Skip to content

gh-104922: Make PY_SSIZE_T_CLEAN not mandatory again #105051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 31, 2023

Conversation

methane
Copy link
Member

@methane methane commented May 29, 2023

This PR makes APIs like PyArg_Parse() accepts # format specifier with ssize_t.
_SizeT variants APIs are now ABI-only if they are part of stable ABI.

  • Update docs
  • Add news entry.
  • Add what's new entry.

@methane
Copy link
Member Author

methane commented May 29, 2023

@vstinner I prefer this PR (PyArg_ParseTuple() now uses Py_ssize_t) over #104923 (PyArg_ParseTuple() keeps raising SystemError for '#' but always #define PyArg_ParseTuple _PyArg_ParseTuple_SizeT.

What do you think?

@methane methane force-pushed the always-ssize_t_clean branch from 954122c to a0af3b5 Compare May 30, 2023 12:54
@vstinner
Copy link
Member

What do you think?

I'm away from Python. You will have to find a different reviewer 😁

@methane
Copy link
Member Author

methane commented May 30, 2023

I removed NEWS entry because current CI workflow doesn't accept path including space.

#103914 (comment)

@methane methane force-pushed the always-ssize_t_clean branch from 238cd95 to cb35202 Compare May 31, 2023 01:07
@methane methane marked this pull request as ready for review May 31, 2023 04:06
@methane methane requested a review from markshannon as a code owner May 31, 2023 04:06
@methane methane merged commit adccff3 into python:main May 31, 2023
@methane methane deleted the always-ssize_t_clean branch May 31, 2023 09:38
yselkowitz added a commit to yselkowitz/vim that referenced this pull request Jun 23, 2024
_PyObject_CallFunction_SizeT was dropped in Python 3.13:

python/cpython#105051

Signed-off-by: Yaakov Selkowitz <[email protected]>
chrisbra pushed a commit to vim/vim that referenced this pull request Jul 4, 2024
…hon 3.13

Problem:  if_py: _PyObject_CallFunction_SizeT is dropped in Python 3.13
Solution: define PyObject_CallFunction for Python >= 3.13
          (Yaakov Selkowitz)

references: python/cpython#105051

closes: #15088

Signed-off-by: Yaakov Selkowitz <[email protected]>
Signed-off-by: Christian Brabandt <[email protected]>
RestorerZ pushed a commit to RestorerZ/fork_vim-orig that referenced this pull request Jul 9, 2024
…hon 3.13

Problem:  if_py: _PyObject_CallFunction_SizeT is dropped in Python 3.13
Solution: define PyObject_CallFunction for Python >= 3.13
          (Yaakov Selkowitz)

references: python/cpython#105051

closes: vim#15088

Signed-off-by: Yaakov Selkowitz <[email protected]>
Signed-off-by: Christian Brabandt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants