GH-62052: add defer_close logic to FileIO #105171
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the FileIO object is wrapped by a write buffer, set the defer_close property to true. That ensures the underlying FileIO object is not closed until the buffer is closed (and can flush the unwritten data). This avoids data loss, as demoed by buffer_not_flushed.py. E.g. if both FileIO and the BufferedWriter are both part of the reference cycle, the finalize triggered by the GC can close the FileIO object before BufferedWriter has a chance to write the data out.
This is a proof-of-concept at this point, not ready to merge.