[3.7] bpo-35214: Fix OOB memory access in unicode escape parser (GH-10506) #10522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0506) Discovered using clang's MemorySanitizer when it ran python3's test_fstring test_misformed_unicode_character_name. An msan build will fail by simply executing: ./python -c 'u"\N"' (cherry picked from commit 746b2d3) Co-authored-by: Gregory P. Smith <[email protected]>
bedevere-bot
added
type-bug
gpshead
approved these changes
Nov 13, 2018
|
@gpshead: Status check is done, and it's a success ✅ . |
1 similar comment
|
@gpshead: Status check is done, and it's a success ✅ . |
|
@gpshead any reason you removed the "awaiting review" label? That is the reason this PR was not automerged. |
|
The label changes look like a race condition between bedevere-bot and myself, it made the +merge -review change at the same time i had the page open and manually selected +automerge. I suspect github's UI RPC call for this probably sends the whole label list rather than just the deltas over what the user thought was there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered using clang's MemorySanitizer when it ran python3's
test_fstring test_misformed_unicode_character_name.
An msan build will fail by simply executing: ./python -c 'u"\N"'
(cherry picked from commit 746b2d3)
Co-authored-by: Gregory P. Smith [email protected]
https://bugs.python.org/issue35214