Skip to content

gh-106751: Optimize _PolllikeSelector for many iteration case #106884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 20, 2023
Merged

gh-106751: Optimize _PolllikeSelector for many iteration case #106884

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c9ef467
optimize _PolllikeSelector
eendebakpt Jul 19, 2023
6bc1087
whitespace
eendebakpt Jul 19, 2023
ff2157f
Update Lib/selectors.py
eendebakpt Jul 19, 2023
119f01c
fix typo; convert register as well
eendebakpt Jul 19, 2023
e871b1b
Merge branch 'polllikeselector' of githubeendebakpt:eendebakpt/cpytho…
eendebakpt Jul 19, 2023
d367470
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 19, 2023
f60f887
Update Lib/selectors.py
eendebakpt Jul 19, 2023
fa72c2a
Merge branch 'main' into polllikeselector
eendebakpt Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions Lib/selectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,11 +369,8 @@ def modify(self, fileobj, events, data=None):

changed = False
if events != key.events:
selector_events = 0
if events & EVENT_READ:
selector_events |= self._EVENT_READ
if events & EVENT_WRITE:
selector_events |= self._EVENT_WRITE
selector_events = ((events & EVENT_READ and self._EVENT_READ)
| (events & EVENT_WRITE and self._EVENT_WRITE) )
try:
self._selector.modify(key.fd, selector_events)
except:
Expand Down Expand Up @@ -404,15 +401,12 @@ def select(self, timeout=None):
fd_event_list = self._selector.poll(timeout)
except InterruptedError:
return ready
fd_to_key_get = self._fd_to_key.get
for fd, event in fd_event_list:
events = 0
if event & ~self._EVENT_READ:
events |= EVENT_WRITE
if event & ~self._EVENT_WRITE:
events |= EVENT_READ

key = self._fd_to_key.get(fd)
key = fd_to_key_get(fd)
if key:
events = ( (event & ~self._EVENT_READ and EVENT_WRITE)
| (event & ~self.EVENT_WRITE and EVENT_READ))
ready.append((key, events & key.events))
return ready

Expand Down