Skip to content

gh-107298: Fix yet more Sphinx warnings in the C API doc #107345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2023
Merged

gh-107298: Fix yet more Sphinx warnings in the C API doc #107345

merged 2 commits into from
Jul 27, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 27, 2023 •
edited by github-actions bot
Loading

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir topic-C-API needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 27, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 27, 2023
Closed
vstinner
vstinner approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, I like your PR title :-D

@serhiy-storchaka serhiy-storchaka merged commit 9833052 into python:main Jul 27, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 983305268e2291b0a7835621b81bf40cba7c27f3 3.12

@serhiy-storchaka serhiy-storchaka deleted the docs-capi-warns branch July 27, 2023 15:44
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 983305268e2291b0a7835621b81bf40cba7c27f3 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 28, 2023
@serhiy-storchaka
[3.12] pythongh-107298: Fix yet more Sphinx warnings in the C API doc (…
47dcb53 
…pythonGH-107345)

(cherry picked from commit 9833052)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

GH-107380 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 28, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 28, 2023
@serhiy-storchaka
[3.12] gh-107298: Fix yet more Sphinx warnings in the C API doc (GH-1…
4014869 
…07345) (GH-107380)

(cherry picked from commit 9833052)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 28, 2023
@serhiy-storchaka
[3.11] pythongh-107298: Fix yet more Sphinx warnings in the C API doc (…
d9967a6 
…pythonGH-107345).

(cherry picked from commit 9833052)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

GH-107381 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 28, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 28, 2023
@serhiy-storchaka
[3.11] gh-107298: Fix yet more Sphinx warnings in the C API doc (GH-1…
d9392c0 
…07345) (GH-107381)

(cherry picked from commit 9833052)
@vstinner
Copy link
Member

I will be avoid next 2 weeks. If you want to backport my recent C API doc fixes to 3.11 and 3.12, go ahead. My plan was to backport a batch of changes in a single commit to 3.12, and backport this one to 3.11. But I'm out of time now.

@vstinner
Copy link
Member

I will be avoid next 2 weeks. If you want to backport my recent C API doc fixes to 3.11 and 3.12, go ahead

Aaaah, that's exactly what you did, thanks! :-)

@serhiy-storchaka serhiy-storchaka removed their assignment Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news topic-C-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @vstinner