-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-106368: Increase test coverage for Argument Clinic #107514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
erlend-aasland
commented
Jul 31, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Increase Argument Clinic test coverage #106368
With this, we're pretty good covered (above 90%). AFAICS, converters, return converters, and most parser code has been tested. Most of what's missing is various error paths. I suggest we close the linked issue after landing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .py tests LGTM! Nikita's almost certainly a better reviewer for the functional tests :)
Thanks for the review; Nikita gave a thumbs up for the functional tests earlier, so I'll enable auto-merge 🚀 |
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, @erlend-aasland, I could not cleanly backport this to |
Sorry, @erlend-aasland, I could not cleanly backport this to |
3.11 and 3.12 never got their backports but I'm removing the labels (I'm going through PRs to see if we did not forgot a backport) (not sure if you want to backport this on 3.12) |