Skip to content

gh-107614: Normalise Argument Clinic error messages #107615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 4, 2023
Merged

gh-107614: Normalise Argument Clinic error messages #107615

merged 10 commits into from
Aug 4, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 4, 2023 •
edited by bedevere-bot
Loading

  • always wrap the offending line, token, or name in quotes
  • always put the entire error message on one line

@erlend-aasland
pythongh-107614: Normalise Argument Clinic error messages
c66a492 
- always wrap the offending line, token, or name in quotes
- always put the entire error message on one line
@bedevere-bot bedevere-bot mentioned this pull request Aug 4, 2023
Closed
@erlend-aasland erlend-aasland mentioned this pull request Aug 4, 2023
Merged
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Aug 4, 2023 •
edited
Loading

Depends on gh-107611 (or the other way around; either way, we'll have conflicts)

erlend-aasland
erlend-aasland commented Aug 4, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to keep line lengths below 90, where reasonable:

@erlend-aasland
Copy link
Contributor Author

Some suggestions to keep line lengths below 90, where reasonable:

Thanks; applied!

AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Aug 4, 2023
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@erlend-aasland
Copy link
Contributor Author

Looks great, thank you!

Thanks for the helpful review and suggestions!

@erlend-aasland erlend-aasland enabled auto-merge (squash) August 4, 2023 11:33
@erlend-aasland erlend-aasland merged commit ac7605e into python:main Aug 4, 2023
@erlend-aasland erlend-aasland deleted the clinic/normalise-error-messages branch August 4, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @AlexWaygood @bedevere-bot