gh-107805: Fix signatures of module-level generated functions in turtle
#107807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that this can go into rc2, because it fixes a bug which makes |
gpshead
added
type-bug
gpshead
requested changes
Aug 10, 2023
serhiy-storchaka
approved these changes
Aug 11, 2023
gpshead
reviewed
Aug 18, 2023
Lib/test/test_turtle.py
Outdated
| 'pen': '(pen=None, **pendict)', | ||
| } | ||
|
|
||
| for name in turtle.__all__: |
There was a problem hiding this comment.
The purpose of this test is only to verify known signatures, correct?
In that case, looping over known_signatures.items() rather than turtle.__all__ makes more sense. Otherwise a typo in a known_signatures name key would go silently unnoticed and we're otherwise creating subtests for all names in turtle even though most of them don't test anything.
serhiy-storchaka
requested changes
Aug 18, 2023
|
I've addressed @gpshead comments about the test case, but I don't think that I can actually test these functions:
If anyone wants to contribute some |
serhiy-storchaka
approved these changes
Aug 27, 2023
gpshead
approved these changes
Sep 1, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 1, 2023
…n `turtle` (pythonGH-107807) (cherry picked from commit 044b8b3) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Sep 1, 2023
…in `turtle` (GH-107807) (#108749) gh-107805: Fix signatures of module-level generated functions in `turtle` (GH-107807) (cherry picked from commit 044b8b3) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we are using
inspect.signaturewhich works correct for all possible parameter types.There are no
/params to test it, but it uses the same branch as regular pos-or-keyword params, so it should be fine.Related #103974
turtle.teleporthas incorrect-ish signature #107805