Skip to content

[3.12] gh-108303: Add Lib/test/test_cppext/ sub-directory (GH-108325) #108328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 22, 2023

  • Move test_cppext to its own directory
  • Rename setup_testcppext.py to setup.py
  • Rename _testcppext.cpp to extension.cpp
  • The source (extension.cpp) is now also copied by the test.
    (cherry picked from commit 21dda09)

Co-authored-by: Victor Stinner [email protected]

…8325)

* Move test_cppext to its own directory
* Rename setup_testcppext.py to setup.py
* Rename _testcppext.cpp to extension.cpp
* The source (extension.cpp) is now also copied by the test.
(cherry picked from commit 21dda09)

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

I tested manually the PR on Linux: ./python -m test test_cppext pass.

@Yhg1s Yhg1s merged commit b539dd3 into python:3.12 Aug 22, 2023
@miss-islington miss-islington deleted the backport-21dda09-3.12 branch August 22, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants