Skip to content

gh-108494: Build _testclinic_limited on Windows #108589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2023
Merged

gh-108494: Build _testclinic_limited on Windows #108589

merged 1 commit into from
Aug 28, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 28, 2023 •
edited
Loading

Add _testclinic_limited project to the Visual Studio solution:

  • In PCbuild/, copy _asyncio.vcxproj to _testclinic_limited.vcxproj,
    replace RootNamespace with "_testclinic_limited".
  • In Visual Stuido, open PCbuild\pcbuild.sln, add the existing
    "_testclinic_limited" project to the solution.
  • Add a dependency from "python" project to "_testclinic_limited"
    project.
  • Save and exit VS.
  • Add "_testclinic_limited" to
    in PCbuild\pcbuild.proj.

@bedevere-bot bedevere-bot mentioned this pull request Aug 28, 2023
Closed
@vstinner vstinner force-pushed the ac_build_test_limited_win branch from 46c8d54 to 4c79ccb Compare August 28, 2023 23:20
@vstinner vstinner changed the title gh-108494: AC: Build _testclinic_limited on Windows gh-108494: Build _testclinic_limited on Windows Aug 28, 2023
@vstinner vstinner marked this pull request as ready for review August 28, 2023 23:21
@vstinner vstinner requested a review from a team as a code owner August 28, 2023 23:21
@vstinner
pythongh-108494: Build _testclinic_limited on Windows
07d21ec 
Add _testclinic_limited project to the Visual Studio solution:

* In PCbuild/, copy _asyncio.vcxproj to _testclinic_limited.vcxproj,
  replace RootNamespace with "_testclinic_limited".
* In Visual Stuido, open PCbuild\pcbuild.sln, add the existing
  "_testclinic_limited" project to the solution.
* Add a dependency from "python" project to "_testclinic_limited"
  project.
* Save and exit VS.
* Add "_testclinic_limited" to <TestModules Include="...">
  in PCbuild\pcbuild.proj.
@vstinner vstinner force-pushed the ac_build_test_limited_win branch from 4c79ccb to 07d21ec Compare August 28, 2023 23:26
@vstinner
Copy link
Member Author

The _testclinic_limited is now build as expected on Windows. Logs of the Windows x64 GHA CI:

  _testclinic_limited.c
     Creating library D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.lib and object D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.exp
  _testclinic_limited.vcxproj -> D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.pyd

@vstinner vstinner enabled auto-merge (squash) August 28, 2023 23:33
@vstinner vstinner merged commit 5c68cba into python:main Aug 28, 2023
@vstinner vstinner mentioned this pull request Aug 28, 2023
Merged
@vstinner vstinner deleted the ac_build_test_limited_win branch August 28, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @bedevere-bot