gh-90805: make sure test_functools works with and without _functoolsmodule
#108644
+28
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctoolsmodule`
serhiy-storchaka
approved these changes
Sep 9, 2023
serhiy-storchaka
approved these changes
Sep 11, 2023
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2023
…toolsmodule (pythonGH-108644) (cherry picked from commit baa6dc8) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-109274 is a backport of this pull request to the 3.11 branch. |
|
GH-109275 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2023
…toolsmodule (pythonGH-108644) (cherry picked from commit baa6dc8) Co-authored-by: Nikita Sobolev <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Sep 11, 2023
…ctoolsmodule (GH-108644) (GH-109274) (cherry picked from commit baa6dc8) Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new take on my old PR :)
Refs #31141
test_functoolsunexpected failures when C_functoolsmoduleis missing #90805