Skip to content

[3.7] bpo-35296: make install now installs the internal API (GH-10665) #10897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2018
Merged

[3.7] bpo-35296: make install now installs the internal API (GH-10665) #10897

merged 2 commits into from
Dec 4, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 4, 2018 •
edited by bedevere-bot
Loading

https://bugs.python.org/issue35296

@vstinner
bpo-35296: make install now installs the internal API (GH-10665)
9914eb7 
make install now also installs the internal API: Include/internal/*.h
header files.

(cherry picked from commit f653fd4)
@vstinner
Windows installer now also install Include/internal/
72e37f9 
The Windows installer (MSI) now also install header files of the
Include/internal/ subdirectory.
@vstinner vstinner requested a review from a team as a code owner December 4, 2018 16:12
@vstinner vstinner requested review from zooba and pitrou December 4, 2018 16:15
@vstinner
Copy link
Member Author

vstinner commented Dec 4, 2018

@zooba: I already modified the installer in master, but here I would like to make the same change in Python 3.7.

zooba
zooba approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the Windows part of the change.

@vstinner vstinner merged commit b02774f into python:3.7 Dec 4, 2018
@vstinner vstinner deleted the install_internals branch December 4, 2018 20:28
@vstinner
Copy link
Member Author

vstinner commented Dec 4, 2018

@pitrou approved the backport by email: https://mail.python.org/pipermail/python-dev/2018-December/155922.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

@pitrou pitrou Awaiting requested review from pitrou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @zooba @the-knights-who-say-ni @bedevere-bot