gh-108511: Add C API functions which do not silently ignore errors #109025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following functions: * PyObject_HasAttrWithError() * PyObject_HasAttrStringWithError() * PyMapping_HasKeyWithError() * PyMapping_HasKeyStringWithError()
serhiy-storchaka
requested review from
kumaraditya303,
markshannon and
methane
as code owners
methane
approved these changes
Sep 12, 2023
serhiy-storchaka
deleted the
PyObject_HasAttrWithError-PyMapping_HasKeyWithError
branch
|
|
|
|
|
|
|
|
I wrote a first PR to add PyMapping_HasKeyWithError() and PyMapping_HasKeyStringWithError() functions to pythoncapi-compat: python/pythoncapi-compat#73 |
csm10495
pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
…ors (pythonGH-109025) Add the following functions: * PyObject_HasAttrWithError() * PyObject_HasAttrStringWithError() * PyMapping_HasKeyWithError() * PyMapping_HasKeyStringWithError()
scoder
reviewed
Oct 15, 2023
|
|
||
| Return ``1`` if the mapping object has the key *key* and ``0`` otherwise. | ||
| This is equivalent to the Python expression ``key in o``. | ||
| On failure, return ``-1``. |
There was a problem hiding this comment.
Given the relevance of error handling for these new functions, I think the docs should mention explicitly under which conditions users must expect exceptions.
Suggested change
| On failure, return ``-1``. | |
| On failure, return ``-1`` with an exception set. |
There was a problem hiding this comment.
Sometimes I write "On error, raise an exception and return -1." Even if in C, technically, it's more "setting" an exception, I like to use Python "raise" semantics in C, it's easy for me to map C/Python this way :-)
|
|
||
| Returns ``1`` if *o* has the attribute *attr_name*, and ``0`` otherwise. | ||
| This is equivalent to the Python expression ``hasattr(o, attr_name)``. | ||
| On failure, return ``-1``. |
There was a problem hiding this comment.
Given the relevance of error handling for these new functions, I think the docs should mention explicitly under which conditions users must expect exceptions.
Suggested change
| On failure, return ``-1``. | |
| On failure, return ``-1`` with an exception set. |
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
May 19, 2025
The simulator needs to be tested with Python 3.12 - it presently does
not fully work on Python 3.13 due to the change in behaviour for
`PyObject_HasAttr()` to no longer silently ignore all errors as it did
previously.
Numba's typecode fingerprinting calls something which is approximately
`PyObject_HasAttr("_numba_type_")` on NumPy arrays during some execution
paths of the simulator, which causes NumPy to raise `ValueError("no
field of name _numba_type_")`. Since Python 3.13 this causes masses of
warnings to be raised that flood the output.
References:
- Python 3.12 `PyObject_HasAttr()`:
https://docs.python.org/3.12/c-api/object.html#c.PyObject_HasAttr
> "Exceptions that occur when this calls __getattr__() and
> __getattribute__() methods are silently ignored."
- Python 3.13 `PyObject_HasAttr()`:
https://docs.python.org/3.13/c-api/object.html#c.PyObject_HasAttr
> "Exceptions that occur when this calls __getattr__() and
> __getattribute__() methods aren’t propagated, but instead given to
> sys.unraisablehook(). For proper error handling, use
> PyObject_HasAttrWithError(), ..."
- CPython commit adding the recommended functions:
python/cpython#109025
- CPython issue: python/cpython#108511
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
May 19, 2025
The simulator needs to be tested with Python 3.12 - it presently does
not fully work on Python 3.13 due to the change in behaviour for
`PyObject_HasAttr()` to no longer silently ignore all errors as it did
previously.
Numba's typecode fingerprinting calls something which is approximately
`PyObject_HasAttr("_numba_type_")` on NumPy arrays during some execution
paths of the simulator, which causes NumPy to raise `ValueError("no
field of name _numba_type_")`. Since Python 3.13 this causes masses of
warnings to be raised that flood the output.
References:
- Python 3.12 `PyObject_HasAttr()`:
https://docs.python.org/3.12/c-api/object.html#c.PyObject_HasAttr
> "Exceptions that occur when this calls __getattr__() and
> __getattribute__() methods are silently ignored."
- Python 3.13 `PyObject_HasAttr()`:
https://docs.python.org/3.13/c-api/object.html#c.PyObject_HasAttr
> "Exceptions that occur when this calls __getattr__() and
> __getattribute__() methods aren’t propagated, but instead given to
> sys.unraisablehook(). For proper error handling, use
> PyObject_HasAttrWithError(), ..."
- CPython commit adding the recommended functions:
python/cpython#109025
- CPython issue: python/cpython#108511
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
May 20, 2025
The simulator needs to be tested with Python 3.12 - it presently does
not fully work on Python 3.13 due to the change in behaviour for
`PyObject_HasAttr()` to no longer silently ignore all errors as it did
previously.
Numba's typecode fingerprinting calls something which is approximately
`PyObject_HasAttr("_numba_type_")` on NumPy arrays during some execution
paths of the simulator, which causes NumPy to raise `ValueError("no
field of name _numba_type_")`. Since Python 3.13 this causes masses of
warnings to be raised that flood the output.
References:
- Python 3.12 `PyObject_HasAttr()`:
https://docs.python.org/3.12/c-api/object.html#c.PyObject_HasAttr
> "Exceptions that occur when this calls __getattr__() and
> __getattribute__() methods are silently ignored."
- Python 3.13 `PyObject_HasAttr()`:
https://docs.python.org/3.13/c-api/object.html#c.PyObject_HasAttr
> "Exceptions that occur when this calls __getattr__() and
> __getattribute__() methods aren’t propagated, but instead given to
> sys.unraisablehook(). For proper error handling, use
> PyObject_HasAttrWithError(), ..."
- CPython commit adding the recommended functions:
python/cpython#109025
- CPython issue: python/cpython#108511
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
May 20, 2025
The simulator needs to be tested with Python 3.12 - it presently does
not fully work on Python 3.13 due to the change in behaviour for
`PyObject_HasAttr()` to no longer silently ignore all errors as it did
previously.
Numba's typecode fingerprinting calls something which is approximately
`PyObject_HasAttr("_numba_type_")` on NumPy arrays during some execution
paths of the simulator, which causes NumPy to raise `ValueError("no
field of name _numba_type_")`. Since Python 3.13 this causes masses of
warnings to be raised that flood the output.
References:
- Python 3.12 `PyObject_HasAttr()`:
https://docs.python.org/3.12/c-api/object.html#c.PyObject_HasAttr
> "Exceptions that occur when this calls __getattr__() and
> __getattribute__() methods are silently ignored."
- Python 3.13 `PyObject_HasAttr()`:
https://docs.python.org/3.13/c-api/object.html#c.PyObject_HasAttr
> "Exceptions that occur when this calls __getattr__() and
> __getattribute__() methods aren’t propagated, but instead given to
> sys.unraisablehook(). For proper error handling, use
> PyObject_HasAttrWithError(), ..."
- CPython commit adding the recommended functions:
python/cpython#109025
- CPython issue: python/cpython#108511
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
May 20, 2025
The simulator needs to be tested with Python 3.12 - it presently does
not fully work on Python 3.13 due to the change in behaviour for
`PyObject_HasAttr()` to no longer silently ignore all errors as it did
previously.
Numba's typecode fingerprinting calls something which is approximately
`PyObject_HasAttr("_numba_type_")` on NumPy arrays during some execution
paths of the simulator, which causes NumPy to raise `ValueError("no
field of name _numba_type_")`. Since Python 3.13 this causes masses of
warnings to be raised that flood the output.
References:
- Python 3.12 `PyObject_HasAttr()`:
https://docs.python.org/3.12/c-api/object.html#c.PyObject_HasAttr
> "Exceptions that occur when this calls __getattr__() and
> __getattribute__() methods are silently ignored."
- Python 3.13 `PyObject_HasAttr()`:
https://docs.python.org/3.13/c-api/object.html#c.PyObject_HasAttr
> "Exceptions that occur when this calls __getattr__() and
> __getattribute__() methods aren’t propagated, but instead given to
> sys.unraisablehook(). For proper error handling, use
> PyObject_HasAttrWithError(), ..."
- CPython commit adding the recommended functions:
python/cpython#109025
- CPython issue: python/cpython#108511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following functions:
📚 Documentation preview 📚: https://cpython-previews--109025.org.readthedocs.build/