-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-109182: Fix and improve tests for gh-108654 #109189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the use of with self.subTest(...)
when a test case is checking two related cases. It's not a huge deal, but it keeps the two cases independent, so that if the first one fails, the second one still runs instead of being silently skipped, so that a single run of the tests can give a fuller picture of the state of the system under test.
Otherwise, these changes look like clear improvements to the comprehensiveness (and readability) of the tests. Thank you!
|
Thank you for your review @carljm. |
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…109189) (cherry picked from commit c0f488b) Co-authored-by: Serhiy Storchaka <[email protected]>
GH-109271 is a backport of this pull request to the 3.12 branch. |
Oh, good point! So we already will get independent failures for all six cases. The only thing we lose by eliminating the outer Ok, then I am happy with these changes as is! |
test_listcomps
fails when run with-We
#109182