Skip to content

Update workflow permissions in require-pr-label Action #109342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2023
Merged

Update workflow permissions in require-pr-label Action #109342

merged 1 commit into from
Sep 12, 2023

Conversation

Mariatta
Copy link
Member

Change the permission from read to write.

@Mariatta
Update workflow permissions in require-pr-label Action
445dca1 
Change the permission from `read` to `write`.
hugovk
hugovk approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches https://github.com/marketplace/actions/require-labels#complete-example and we're hoping will avoid "Approve and run" showing up for removed (but not added) labels by Bedevere.

@Mariatta Mariatta enabled auto-merge (squash) September 12, 2023 18:44
@Mariatta Mariatta merged commit 44c8699 into python:main Sep 12, 2023
@Mariatta Mariatta deleted the Mariatta-patch-6 branch September 12, 2023 19:04
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 12, 2023
@miss-islington
Copy link
Contributor

Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @Mariatta, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 44c8699196c1951037bc549c895ea5af26c7254e 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2023
@Mariatta @miss-islington
Update workflow permissions in require-pr-label Action (pythonGH-109342)
26f3cb2 
Change the permission from `read` to `write`.
(cherry picked from commit 44c8699)

Co-authored-by: Mariatta <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 12, 2023

GH-109348 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 12, 2023
@Mariatta Mariatta added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Sep 12, 2023
@miss-islington
Copy link
Contributor

Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @Mariatta, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 44c8699196c1951037bc549c895ea5af26c7254e 3.11

@bedevere-app
Copy link

bedevere-app bot commented Sep 12, 2023

GH-109354 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 12, 2023
hugovk pushed a commit that referenced this pull request Sep 13, 2023
@Mariatta
[3.11] Update workflow permissions in require-pr-label Action (GH-109342
df21fdc 
) (#109354)

Change the permission from `read` to `write`..
(cherry picked from commit 44c8699)
Yhg1s pushed a commit that referenced this pull request Sep 13, 2023
@miss-islington @Mariatta
[3.12] Update workflow permissions in require-pr-label Action (GH-109342
aee0077 
) (#109348)

Update workflow permissions in require-pr-label Action (GH-109342)

Change the permission from `read` to `write`.
(cherry picked from commit 44c8699)

Co-authored-by: Mariatta <[email protected]>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Sep 13, 2023
@Mariatta @vstinner
Update workflow permissions in require-pr-label Action (python#109342)
453ffa8 
Change the permission from `read` to `write`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

@Mariatta Mariatta

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mariatta @miss-islington @hugovk