gh-109582: test_fork_signal_handling should wait for event #109605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorcio
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
|
Does this need a changelog entry? The failing test was introduced in 3.12. |
No, because it's just a test fix. |
vstinner
approved these changes
Sep 21, 2023
| @@ -1911,8 +1913,14 @@ def test_fork_signal_handling(self): | |||
| parent_handled = manager.Event() | |||
|
|
|||
There was a problem hiding this comment.
I didn't know that another test_asyncio test uses multiprocessing.
It might be interesting to call from multiprocessing.util._cleanup_tests() in this test file as well: see commit 09ea4b8 and gh-109295.
But this one is less important since it doesn't pull most heavy multiprocessing resources, it's "just" a fork manager :-)
| child_started.set() | ||
| while True: | ||
| time.sleep(1) |
There was a problem hiding this comment.
It took me a while to understand that the child doesn't run the loop forever, but is interrupted by SIGTERM and so exits immediately.
| @@ -1933,6 +1941,7 @@ async def func(): | |||
|
|
|||
| asyncio.run(main()) | |||
|
|
|||
| child_handled.wait(timeout=support.SHORT_TIMEOUT) | |||
There was a problem hiding this comment.
Right, that's a good way to synchronize the parent and the child.
|
Merged thanks. I copied your rationale in the commit message. IMO it's important to keep it. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 21, 2023
…honGH-109605) Sometimes the child_handled event was missing because either the child quits before it gets a chance to handle the signal, or the parent asserts before the event notification is delivered via IPC. Synchronize explicitly to avoid this. (cherry picked from commit 608c1f3) Co-authored-by: Davide Rizzo <[email protected]>
|
GH-109695 is a backport of this pull request to the 3.12 branch. |
|
|
csm10495
pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
…hon#109605) Sometimes the child_handled event was missing because either the child quits before it gets a chance to handle the signal, or the parent asserts before the event notification is delivered via IPC. Synchronize explicitly to avoid this.
Yhg1s
pushed a commit
that referenced
this pull request
Oct 2, 2023
…-109605) (#109695) gh-109582: test_fork_signal_handling should wait for event (GH-109605) Sometimes the child_handled event was missing because either the child quits before it gets a chance to handle the signal, or the parent asserts before the event notification is delivered via IPC. Synchronize explicitly to avoid this. (cherry picked from commit 608c1f3) Co-authored-by: Davide Rizzo <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…hon#109605) Sometimes the child_handled event was missing because either the child quits before it gets a chance to handle the signal, or the parent asserts before the event notification is delivered via IPC. Synchronize explicitly to avoid this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the child_handled event was missing because either the child quits before it gets a chance to handle the signal, or the parent asserts before the event notification is delivered via IPC. Synchronize explicitly to avoid this.